Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751341AbdHaJkk (ORCPT ); Thu, 31 Aug 2017 05:40:40 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:34088 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbdHaJki (ORCPT ); Thu, 31 Aug 2017 05:40:38 -0400 X-Google-Smtp-Source: ADKCNb6+4CqoBk9MxLDHs8d0dqAmH5JxG6JAPqCUxWpQ8Fvd096GOLVbMLtbb/D2O/xCJ0ZHw0d1/g== Subject: Re: [PATCH 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode To: Yoshihiro Shimoda , kishon@ti.com Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <1504164672-20677-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1504164672-20677-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> From: Sergei Shtylyov Message-ID: <3a5b6050-01c6-1f92-7d79-42b74c692e3c@cogentembedded.com> Date: Thu, 31 Aug 2017 12:40:34 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1504164672-20677-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 568 Lines: 18 Hello! On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote: > The previous code assumed a channel has otg capability if a channel > has interrupt property. But, it is not good because: > - Battery charging feature also needs interrupt property. > - Some R-Car Gen3 SoCs (e.g. R-Car D3) doesn't have OTG capability. Don't. > So, this patch checks whether usb 2.0 host node has dr_mode property or > not. If it has 'dr_mode = "otg";', this driver enables otg capability. > > Signed-off-by: Yoshihiro Shimoda [...] MBR, Sergei