Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751792AbdHaKY2 (ORCPT ); Thu, 31 Aug 2017 06:24:28 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:8683 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763AbdHaKY0 (ORCPT ); Thu, 31 Aug 2017 06:24:26 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 31 Aug 2017 03:24:16 -0700 Subject: Re: [PATCH 1/2] iommu/tegra: Add support for struct iommu_device To: Joerg Roedel CC: Thierry Reding , Robin Murphy , , , , Joerg Roedel References: <1502317752-8792-1-git-send-email-joro@8bytes.org> <1502317752-8792-2-git-send-email-joro@8bytes.org> <20170830120902.kqtxh2ls4ob7xpwy@8bytes.org> <20170830153034.GK19533@8bytes.org> From: Jon Hunter Message-ID: <8822281c-1188-1135-2cd3-68f988761cd8@nvidia.com> Date: Thu, 31 Aug 2017 11:23:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170830153034.GK19533@8bytes.org> X-Originating-IP: [10.21.132.162] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 621 Lines: 22 Hi Joerg, On 30/08/17 16:30, Joerg Roedel wrote: > Hi Jon, > > On Wed, Aug 30, 2017 at 03:22:05PM +0100, Jon Hunter wrote: >> Yes I can confirm that this fixes the crash. I assume that you will fix >> the error path for bus_set_iommu() above as I believe now it needs to >> call iommu_device_sysfs_remove(). > > Thanks for testing the patch. I updated the error-path and put the > commit below into the iommu-tree: Today's -next is still failing and I don't see this fix in your public tree yet [0]. Can you push this out? Cheers Jon [0] https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git/ -- nvpublic