Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751434AbdHaMTl (ORCPT ); Thu, 31 Aug 2017 08:19:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59572 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751227AbdHaMTk (ORCPT ); Thu, 31 Aug 2017 08:19:40 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C350A5AFED Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=asavkov@redhat.com Date: Thu, 31 Aug 2017 14:19:37 +0200 From: Artem Savkov To: Michal Hocko Cc: Thomas Gleixner , "Paul E. McKenney" , LKML , Johannes Weiner , linux-mm@kvack.org Subject: Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem Message-ID: <20170831121908.kin3mm25ebszhpvn@shodan.usersys.redhat.com> References: <20170807140947.nhfz2gel6wytl6ia@shodan.usersys.redhat.com> <20170830141543.qhipikpog6mkqe5b@dhcp22.suse.cz> <20170830154315.sa57wasw64rvnuhe@dhcp22.suse.cz> <20170831111006.i7srs56xki4bjx34@shodan.usersys.redhat.com> <20170831120951.hqlu2ai5i7hly7nk@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170831120951.hqlu2ai5i7hly7nk@dhcp22.suse.cz> User-Agent: NeoMutt/20161126 (1.7.1) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 31 Aug 2017 12:19:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 21 On Thu, Aug 31, 2017 at 02:09:51PM +0200, Michal Hocko wrote: > On Thu 31-08-17 13:10:06, Artem Savkov wrote: > > Hi Michal, > > > > On Wed, Aug 30, 2017 at 05:43:15PM +0200, Michal Hocko wrote: > > > The previous patch is insufficient. drain_all_stock can still race with > > > the memory offline callback and the underlying memcg disappear. So we > > > need to be more careful and pin the css on the memcg. This patch > > > instead... > > > > Tried this on top of rc7 and it does fix the splat for me. > > Thanks for testing! Can I assume your Tested-by? Didn't test much more than the case that was causing it, but yes. Reported-and-tested-by: Artem Savkov -- Regards, Artem