Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751479AbdHaMpi (ORCPT <rfc822;w@1wt.eu>);
        Thu, 31 Aug 2017 08:45:38 -0400
Received: from mx2.suse.de ([195.135.220.15]:40056 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751405AbdHaMph (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 31 Aug 2017 08:45:37 -0400
Date: Thu, 31 Aug 2017 14:45:35 +0200 (CEST)
From: Miroslav Benes <mbenes@suse.cz>
To: Joe Lawrence <joe.lawrence@redhat.com>
cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        Josh Poimboeuf <jpoimboe@redhat.com>, Jessica Yu <jeyu@redhat.com>,
        Jiri Kosina <jikos@kernel.org>, Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v4] livepatch: introduce shadow variable API
In-Reply-To: <2fc0160b-d16a-97d3-3ea1-4a787b8afd48@redhat.com>
Message-ID: <alpine.LSU.2.21.1708311444540.5054@san.suse.cz>
References: <1502740963-31310-1-git-send-email-joe.lawrence@redhat.com> <1502740963-31310-2-git-send-email-joe.lawrence@redhat.com> <alpine.LSU.2.20.1708161423040.4165@pobox.suse.cz> <2fc0160b-d16a-97d3-3ea1-4a787b8afd48@redhat.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 317
Lines: 12


> > Could you also add a comment above klp_shadow_lock definition about what 
> > it aims to protect?
> > 
> 
> How about "klp_shadow_lock provides exclusive access to the
> klp_shadow_hash and the shadow variables it references."  or were
> thinking of something more detailed?

No, this is good. Thanks.

Miroslav