Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751483AbdHaNrf (ORCPT <rfc822;w@1wt.eu>);
        Thu, 31 Aug 2017 09:47:35 -0400
Received: from vps0.lunn.ch ([178.209.37.122]:46630 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750911AbdHaNre (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 31 Aug 2017 09:47:34 -0400
Date: Thu, 31 Aug 2017 15:47:24 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: davem@davemloft.net, gregory.clement@free-electrons.com,
        thomas.petazzoni@free-electrons.com, nadavh@marvell.com,
        linux@armlinux.org.uk, linux-kernel@vger.kernel.org, mw@semihalf.com,
        stefanc@marvell.com, miquel.raynal@free-electrons.com,
        netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: mvpp2: use the GoP interrupt for link
 status changes
Message-ID: <20170831134724.GO22289@lunn.ch>
References: <20170831071256.18416-1-antoine.tenart@free-electrons.com>
 <20170831071256.18416-3-antoine.tenart@free-electrons.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170831071256.18416-3-antoine.tenart@free-electrons.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 449
Lines: 15

On Thu, Aug 31, 2017 at 09:12:55AM +0200, Antoine Tenart wrote:
> +static void mvpp22_gop_unmask_irq(struct mvpp2_port *port)
> +{
> +	u32 val;
> +
> +	if (port->phy_interface == PHY_INTERFACE_MODE_RGMII ||
> +	    port->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||
> +	    port->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID ||
> +	    port->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID ||

Hi Antoine

phy_interface_mode_is_rgmii()

	Andrew