Date: Thu, 31 Aug 2017 09:54:15 -0400
From: Josef Bacik <josef@toxicpanda.com>
To: Brendan Jackman <brendan.jackman@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Josef Bacik <josef@toxicpanda.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>
Subject: Re: [PATCH v3 3/5] sched/fair: Fix find_idlest_group when local
 group is not allowed
Message-ID: <20170831135414.r6tutn6c35pt54ci@destiny>
References: <20170831115802.26365-1-brendan.jackman@arm.com>
 <20170831115802.26365-4-brendan.jackman@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170831115802.26365-4-brendan.jackman@arm.com>
User-Agent: NeoMutt/20170714 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 439
Lines: 13

On Thu, Aug 31, 2017 at 12:58:00PM +0100, Brendan Jackman wrote:
> When the local group is not allowed we do not modify this_*_load from
> their initial value of 0. That means that the load checks at the end
> of find_idlest_group cause us to incorrectly return NULL. Fixing the
> initial values to ULONG_MAX means we will instead return the idlest
> remote group in that case.
> 

Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks,

Josef