Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751713AbdHaN6s (ORCPT ); Thu, 31 Aug 2017 09:58:48 -0400 Received: from mail-bl2nam02on0132.outbound.protection.outlook.com ([104.47.38.132]:25824 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750908AbdHaN6q (ORCPT ); Thu, 31 Aug 2017 09:58:46 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Joe.Korty@concurrent-rt.com; Date: Thu, 31 Aug 2017 09:58:40 -0400 From: joe.korty@concurrent-rt.com To: Jesse Gross Cc: linux-kernel@vger.kernel.org Subject: Re: tunnels: Don't apply GRO to multiple layers of encapsulation. Message-ID: <20170831135840.GA19548@zipoli.concurrent-rt.com> Reply-To: "Joe Korty" MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.8.3 (2017-05-23) X-Originating-IP: [12.220.59.2] X-ClientProxiedBy: CY4PR18CA0053.namprd18.prod.outlook.com (10.173.57.143) To CY4PR11MB1478.namprd11.prod.outlook.com (10.172.69.149) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d70ef917-8fe6-4484-abc3-08d4f07864a2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(2017082002075)(300000503095)(300135400095)(2017052603199)(201703131423075)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR11MB1478; X-Microsoft-Exchange-Diagnostics: 1;CY4PR11MB1478;3:mJRpJ2oks8wptIHpkyuajs9GiVmqrRAibvLEDbSM5b68UmKtxI7Sqr3RTJXQ8uVxDtVkQewwDtAKYeyghailuMj+IJefPTwalVcwa73u3azBKUs6RJqPij9sx1Yl+wbKU/3ltFKOBENajmkkGtYsv2jzAQ0E7bQ8XFZJQqeNVtwLvbKhlU8gscC1hXMY5hYj+lllZLaIDNDDnWv+rQO2GPzNliuPCOhFjZ92EBQHdg3vF1veCWsXGW5aWk9YCSYS;25:SRJsfSRlxg1PVEv8Hm91mMqxWedFgkTrR5It2bwMKbNRhDL3hvkVppsTTzS7ECfOIEsxZ0N3PowpvnGjQmwYvuq1GppchNeJrnvOhZi4J3iyXT8vEzdIh/MbNIu1wuK16rO31ts0HXhIJFnwZajL+hoSi7F5ZBVwqVmN69iCU+XueovigbtFTwt6UiuEMqBDXU19uejAxdBKvNgSsJZzjqJYKLX+SWr8LWMYDOV0K3w+49bwExi4yyrwPU+jxDr71C3KjIAutG7mFVI7IS9tx/885T6OBD3eQ12FOGc0KZSgf1XXFfh1ZflnaFPQWabfyFEkt5gdrZswT9BdK3ki8w==;31:grWKIw0u3e8cGpzqUC9We4rj6HAEwXxIxItNGAsVRLKpXpnCILRh14nXPN7gxrh3w8qkw9SHRLBIdZ03IBku08v42DwfzaEGxKVKwMLzTuVwOxwk/BGMQesrk/lcznv/SS+/qDxz7EXfm80wQ1TSC3I4MvTP+7shdIKnwsYTn90U+laV0Uk8XNbgzBAf8jPQR2UvbZqW3aBrROuUzOW9kq/J1PG8WtciZn5Z0dmchbg= X-MS-TrafficTypeDiagnostic: CY4PR11MB1478: X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123562025)(20161123558100)(2016111802025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(6043046)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR11MB1478;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR11MB1478; X-Microsoft-Exchange-Diagnostics: 1;CY4PR11MB1478;4:WigTM+0YFANrUF6TjVSLZB6lAon5FM/jb25urDE5zuLdK3xF4c3z/7b3rbF++C9lOm/f+7WBvEJ+DoDAmzyokTeCBaAT6v4ryQxWVYr2oAtxcqj1n8hcR8mKoti6R9MW7UGQgwCRyuX7ypI3fTpcQnnjD+jPeKC//dzdhmlKQjRzHbGn/YeBg9uKEW3fA3bYMMK0RYsHxRa9yWxGuGbZq999S6t6whtEYE6SoiYLb9M7pwg1ef96AXSF/8oUqNwc X-Forefront-PRVS: 04163EF38A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(199003)(81166006)(3846002)(478600001)(5660300001)(575784001)(86362001)(6916009)(55016002)(2906002)(97736004)(50466002)(25786009)(83506001)(85782001)(66066001)(4001350100001)(106356001)(43066003)(33656002)(110136004)(50986999)(68736007)(53936002)(305945005)(69596002)(9686003)(7736002)(4326008)(105586002)(101416001)(54356999)(229853002)(72206003)(53416004)(8936002)(23726003)(6116002)(8676002)(189998001)(81156014)(47776003)(6246003)(42186005)(1076002)(18370500001)(85772001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR11MB1478;H:zipoli.concurrent-rt.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR11MB1478;23:XSRURhw2YE18CFL9GQJG/dArCnU+XFqZ7QXkd9DWi?= =?us-ascii?Q?3J5lPWENtH61vaNwMb8A+8VU/gpu8wXdA76XDMXPBqonNjSGWFwSExjg+PI+?= =?us-ascii?Q?gk/U5EUxURElb4hpJbBCb0XSKGgX2VOmvosdYMcQclq6gStqmE3HCXPeJipn?= =?us-ascii?Q?Ni0Ngot1n0hGOantDdQ3IAjUPOgIbGqtGg/25l1CDvhsh+bQgvF8gdc58+7V?= =?us-ascii?Q?iWzIiSdPj9c8xi3c/CH28PyMs1YIQxAKgudDywzOVR3/EWyDe6jdeX8kW5/c?= =?us-ascii?Q?HIiFaTZGviAw00XulRFU6iwnIWK++B3dewBjOWWynSDUQkxrPJuZgZ263Jwq?= =?us-ascii?Q?/vtVl8/4UGCDHgruEAh9bJUlXSj53KsbSWaEZMnO2kodEVn4EUH2fjMn3gkq?= =?us-ascii?Q?I9oJQFvzEYVnurhZLHYwSowDMFLo5bExtgT6O0R+6ZYrWgGqv/48moduL5Eo?= =?us-ascii?Q?f3X1b86TVUe+tB5lOsWPdsixzwXZpSOkgNvazJ1tEtep2semFNZdLKr29NF1?= =?us-ascii?Q?+Hrj7L/VFkruzUKS+4vBEZoFrbMSddeNisoZqbg6n1A7N3n9Lq/W5Qpn/KXa?= =?us-ascii?Q?NF1lNjR21BV+UWUDtWPSzssd8yWINcqNvwwdHLfGGQp3SEr2LLPK2b1YaxdT?= =?us-ascii?Q?94UlXARCcMT8iBk6kBqGytPgZNBF5hcfr0c9yRp08OP+hk+aLBpodNmgUsMl?= =?us-ascii?Q?XUK7hEjdcDUMQgY9l5fC/Q/wryXUGoNLIDEyJTe/5yWyJs2WFsfSdz/vSWXu?= =?us-ascii?Q?S4uWb1w+ViuBAeyPrFUaUIM5FmKMjM6jzMkYVmsigagww/gilf4nblSnqpoz?= =?us-ascii?Q?sOcK6psGSI4A8GwLzT0AN0jKnDUezndN7xIOtvmnqbfM+r0ZN5SVQJyS95TT?= =?us-ascii?Q?k5ejaRbn6w9ERGuDXTUmDenZTsNT+CyeqZm5sCuy6hHg41ejChY5UDsirrHl?= =?us-ascii?Q?Ct1fexGJqn1m0bLSHBfUo18ZQT9UQ0YSTqen4oTgzX+jxXounGNylgeqgcbv?= =?us-ascii?Q?4imIWxr91IfEU1E6p/y+gmjyCBPMx31m6e2IVd5ZRKBKM8BL1Mj+q42SoKsk?= =?us-ascii?Q?demTla/EDqz6+OLoKYPE+TpaS/sldS14qU7unBX3GQq3VoIsPm5Bx4ye1whL?= =?us-ascii?Q?dTLDxOVHEI/11JLrymBECcGIVZqjrh3SONyDZoWSmkZgY2HVOz7YpVlsN//b?= =?us-ascii?Q?QTtgMtdF2xkB+E=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR11MB1478;6:S8gtbi3D8GYDrK5jUAqJ4kp3EB610WVRerZ9rvQWplvwrR6DVwtlR2jkMHhKWxiRljnATlh9Kb+FuDK7QnM8saScOsnNkLQ/mnfEZ/xkzLx3+icaPaZhWqWktanetYSUc7P0EGnHaQfw6tNeVo9/fqHn1zIiPyHH/mZA8OlZ7Joj89mCBVSQxhpJfy9Bj9aSwd31N23TaZIdoIDnO29dX8gTyY5iVPQLEb+FDPOJxcHI7ugnTfnxcZrp38m0RH/gDPsxYnhJxrdvrb0XcliPbanuXjgLT/r/biEn7Eyndl+wsSK7V7tXp3U++uIJ3QHbeMuEkjermm6OMreLRTT1gg==;5:gxmtuX7h6Pzie6dbq0rWWIj+0UURgOB5Sg3e2XpDMUGMl0f94lOVIEO5eOlzVgQ7gcJqUbwlfTOvprqk1D5WHqNiaslHZ4lOEGnaOvoxR7xwiFWnxphClYhJqnEctnhPYO6lYq5jrzhBQKzkO9iSww==;24:2aeHk+QaaXMYaBL+jjpjOtMnyVOHuXpDlryddGk3YDgNcx6wTgDXpUkH3AQV66TPvHXVauV+KcYWAJe/qnl4YS4ZCAYVBwYvDjKK9rwBJI8=;7:WfxYG7mOJ6ekuYxRXEodlAtS+os6Smrt6cD0AhP9ZvkYhlalgWHEBNwQL076p4UU1FNIHjHk4uMC+ekOd5x7PNmYX/bFRcyPbD9x4QDqLL3x7qicVddh23alnZCqPH2ENzmJiOd5eRQsqYZtUEsN0BVgQmZ9yEfljXVaYIaAeOfXvuS+KjeBgzsdbuBunqR1u6T6zOvKDuuJpt2qgUbz7G9T1dzXz3jPQ4K4E2ZvxVE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: concurrent-rt.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2017 13:58:43.8237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38747689-e6b0-4933-86c0-1116ee3ef93e X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1478 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 638 Lines: 23 [ resend due to mail problems at my end ] Hi Jesse, The backport of fac8e0f579695a3ecbc4d3cac369139d7f819971, "tunnels: Don't apply GRO to multiple layers of encapsulation", to linux-4.1.y seems to have missed a line. The 4.1 commit is 066b300e5be43cb61697539e2a3a9aac5afb422f. The potentially missing line is: - .gro_receive = ipv6_gro_receive, + .gro_receive = sit_gro_receive, I am not experiencing any bad symptoms. I simply noticed that the patch introduced a new function, sit_gro_receive, without introducing any users, and that same patch in linux-4.4.y does have a user. Regards, Joe