Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751485AbdHaOC0 (ORCPT ); Thu, 31 Aug 2017 10:02:26 -0400 Received: from muru.com ([72.249.23.125]:39010 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbdHaOCZ (ORCPT ); Thu, 31 Aug 2017 10:02:25 -0400 Date: Thu, 31 Aug 2017 07:02:21 -0700 From: Tony Lindgren To: Linus Walleij Cc: Timur Tabi , Grygorii Strashko , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux-OMAP Subject: Re: Regression in next with gpiolib Message-ID: <20170831140221.GK6008@atomide.com> References: <20170830214127.GJ6008@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 28 * Linus Walleij [170830 22:59]: > On Wed, Aug 30, 2017 at 11:41 PM, Tony Lindgren wrote: > > > Hi Timur, Linus & Grygorii, > > > > Looks like commit 108d23e322a2 ("gpiolib: request the gpio before > > querying its direction") caused a regression on at least pandaboard > > es with booting hanging shortly after gpio init. > > > > It seems to be that we're now calling request and free on all gpios > > before they are properly configured? > > > > I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where > > not calling omap_gpio_free() on them makes the system boot again. > > > > These lines are used for the leds in omap4-panda-common.dtsi, and > > omap_gpio_free() will by default set the unused lines for input > > and bad things happen. I guess hardware failure could also happen > > although I have not seen it here. > > > > It seems a similar issue can exist on other platforms too, > > so it's probably a good idea to revert this for now. > > I reverted it for now. OK thanks! Tony