Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751672AbdHaPA3 (ORCPT ); Thu, 31 Aug 2017 11:00:29 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:38580 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbdHaPA2 (ORCPT ); Thu, 31 Aug 2017 11:00:28 -0400 From: Laurent Pinchart To: Himanshu Jha Cc: airlied@linux.ie, tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: omapdrm: hdmi: Use PTR_ERR_OR_ZERO Date: Thu, 31 Aug 2017 18:01:00 +0300 Message-ID: <2927000.82bNJ3FzMp@avalon> In-Reply-To: <1504015212-17828-1-git-send-email-himanshujha199640@gmail.com> References: <1504015212-17828-1-git-send-email-himanshujha199640@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2886 Lines: 85 Hi Himanshu, Thank you for the patch. On Tuesday, 29 August 2017 17:00:12 EEST Himanshu Jha wrote: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Signed-off-by: Himanshu Jha Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/hdmi4.c | 5 +---- > drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 5 +---- > drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 5 +---- > drivers/gpu/drm/omapdrm/dss/hdmi_phy.c | 5 +---- > 4 files changed, 4 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c > b/drivers/gpu/drm/omapdrm/dss/hdmi4.c index f169348..3bf81e1 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c > @@ -676,10 +676,7 @@ static int hdmi_audio_register(struct device *dev) > dev, "omap-hdmi-audio", PLATFORM_DEVID_AUTO, > &pdata, sizeof(pdata)); > > - if (IS_ERR(hdmi.audio_pdev)) > - return PTR_ERR(hdmi.audio_pdev); > - > - return 0; > + return PTR_ERR_OR_ZERO(hdmi.audio_pdev); > } > > /* HDMI HW IP initialisation */ > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c > b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c index 365cf07..aafd723 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c > @@ -922,8 +922,5 @@ int hdmi4_core_init(struct platform_device *pdev, struct > hdmi_core_data *core) > > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core"); > core->base = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(core->base)) > - return PTR_ERR(core->base); > - > - return 0; > + return PTR_ERR_OR_ZERO(core->base); > } > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c > b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c index ab179ec..45c7b0f 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c > @@ -911,8 +911,5 @@ int hdmi5_core_init(struct platform_device *pdev, struct > hdmi_core_data *core) > > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core"); > core->base = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(core->base)) > - return PTR_ERR(core->base); > - > - return 0; > + return PTR_ERR_OR_ZERO(core->base); > } > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c > b/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c index a156292..12a85cb 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c > @@ -194,8 +194,5 @@ int hdmi_phy_init(struct platform_device *pdev, struct > hdmi_phy_data *phy, > > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy"); > phy->base = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(phy->base)) > - return PTR_ERR(phy->base); > - > - return 0; > + return PTR_ERR_OR_ZERO(phy->base); > } -- Regards, Laurent Pinchart