From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "bp@alien8.de" <bp@alien8.de>
CC: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "tony.luck@intel.com" <tony.luck@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac
Thread-Topic: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac
Thread-Index: AQHTHGQ64gYgIKEhTEmknkbrX4SyMaKeVuWAgABWs4A=
Date: Thu, 31 Aug 2017 16:17:07 +0000
Message-ID: <1504195625.2042.179.camel@hpe.com>
References: <20170823225447.15608-1-toshi.kani@hpe.com>
         <20170823225447.15608-4-toshi.kani@hpe.com>
         <20170831105647.a7ypixekv6jybqyu@pd.tnic>
In-Reply-To: <20170831105647.a7ypixekv6jybqyu@pd.tnic>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <9001CA75183E074EB558E88C597B0741@NAMPRD84.PROD.OUTLOOK.COM>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2017 16:17:07.5729
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0028
X-OriginatorOrg: hpe.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v7VGHZkC007337
Content-Length: 1612
Lines: 53

On Thu, 2017-08-31 at 12:56 +0200, Borislav Petkov wrote:
> On Wed, Aug 23, 2017 at 04:54:45PM -0600, Toshi Kani wrote:
 :
> > ---
> >  drivers/edac/ghes_edac.c |   29 ++++++++++++++++++++++++-----
> >  1 file changed, 24 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
> > index 8d904df..0030a09 100644
> > --- a/drivers/edac/ghes_edac.c
> > +++ b/drivers/edac/ghes_edac.c
> > @@ -38,6 +38,10 @@ static struct ghes_edac_pvt *ghes_pvt;
> >   */
> >  static DEFINE_SPINLOCK(ghes_lock);
> >  
> > +/* Set 1 to skip the platform check */
> > +static bool __read_mostly ghes_edac_force_load;
> 
> It is static - "force_load" as a bool name is enough.

Will do.

> > +module_param_named(force_load, ghes_edac_force_load, bool, 0);
> 
> ERROR: Use 4 digit octal (0777) not decimal permissions
> #53: FILE: drivers/edac/ghes_edac.c:43:
> +module_param_named(force_load, ghes_edac_force_load, bool, 0);
> 
> This last param is @perm: visibility in sysfs. Why not visible in
> sysfs?

I followed in the footsteps of 'ghes_disable', which is also a kernel
boot option and uses 0.

> > +
> >  /* Memory Device - Type 17 of SMBIOS spec */
> >  struct memdev_dmi_entry {
> >  	u8 type;
> > @@ -415,6 +419,15 @@ void ghes_edac_report_mem_error(struct ghes
> > *ghes, int sev,
> >  	spin_unlock_irqrestore(&ghes_lock, flags);
> >  }
> >  
> > +/*
> > + * Known systems that are safe to enable this module.
> > + * "ghes_edac.force_load=1" skips this check if necessary.
> 
> Put this second sentence over the parameter definition.

Will do.

Thanks,
-Toshi