Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751964AbdHaQwp (ORCPT ); Thu, 31 Aug 2017 12:52:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48638 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776AbdHaQwo (ORCPT ); Thu, 31 Aug 2017 12:52:44 -0400 Date: Thu, 31 Aug 2017 18:52:47 +0200 From: Greg Kroah-Hartman To: Dan Carpenter Cc: Shaohua Li , linux-block@vger.kernel.org, Jens Axboe , Tejun Heo , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL Message-ID: <20170831165247.GA26219@kroah.com> References: <20170830140456.7n6sfogqb7mvjmrm@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170830140456.7n6sfogqb7mvjmrm@mwanda> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 419 Lines: 14 On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote: > The kernfs_get_inode() returns NULL on error, it never returns error > pointers. > > Fixes: aa8188253474 ("kernfs: add exportfs operations") > Signed-off-by: Dan Carpenter > Acked-by: Tejun Heo Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I can't take this patch :( thanks, greg k-h