Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbdHaRfG (ORCPT ); Thu, 31 Aug 2017 13:35:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36420 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbdHaRfD (ORCPT ); Thu, 31 Aug 2017 13:35:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6A3A1C047B8D Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Thu, 31 Aug 2017 12:34:59 -0500 From: Josh Poimboeuf To: Joe Lawrence Cc: Joao Moreira , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, mbenes@suse.cz, mmarek@suse.cz, pmladek@suse.com, jikos@suse.cz, nstange@suse.de, jroedel@suse.de, matz@suse.de, khlebnikov@yandex-team.ru, jeyu@kernel.org Subject: Re: [PATCH 2/8] kbuild: Support for Symbols.list creation Message-ID: <20170831173459.54dmhu5xjy3m45t6@treble> References: <20170829190140.401-1-jmoreira@suse.de> <20170829190140.401-3-jmoreira@suse.de> <20170831152439.3qmzrrg4atlj5yve@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170831152439.3qmzrrg4atlj5yve@redhat.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 31 Aug 2017 17:35:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 358 Lines: 11 On Thu, Aug 31, 2017 at 11:24:39AM -0400, Joe Lawrence wrote: > > +quiet_cmd_klp_map = LIVEPATCH Symbols.list > > nit: I don't think any other quiet_cmd invocations put a tab between the > label and file list. That said, "LIVEPATCH" is > 8 chars, so it's not > going to line up anyway. Maybe "SYMBOLS" would be more appropriate (and would fit). -- Josh