Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751935AbdHaRi7 (ORCPT ); Thu, 31 Aug 2017 13:38:59 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:37298 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbdHaRi6 (ORCPT ); Thu, 31 Aug 2017 13:38:58 -0400 Subject: Re: [PATCH 3/3 v8] ARC: hsdk: initial port for HSDK board To: Rob Herring , Eugeniy Paltsev CC: arcml , lkml , Alexey Brodkin , "devicetree@vger.kernel.org" Newsgroups: gmane.linux.drivers.devicetree,gmane.linux.kernel.arc,gmane.linux.kernel References: <20170712094023.23226-1-Eugeniy.Paltsev@synopsys.com> <20170712094023.23226-4-Eugeniy.Paltsev@synopsys.com> <20170717173823.lklxhoyylhdxjawa@rob-hp-laptop> From: Vineet Gupta Message-ID: Date: Thu, 31 Aug 2017 10:38:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170717173823.lklxhoyylhdxjawa@rob-hp-laptop> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.108] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2034 Lines: 54 Hi Rob, On 07/17/2017 10:38 AM, Rob Herring wrote: > On Wed, Jul 12, 2017 at 12:40:23PM +0300, Eugeniy Paltsev wrote: >> From: Alexey Brodkin >> >> This initial port adds support of ARC HS Development Kit board with some >> basic features such serial port, USB, SD/MMC and Ethernet. >> >> Essentially we run Linux kernel on all 4 cores (i.e. utilize SMP) and >> heavily use IO Coherency for speeding-up DMA-aware peripherals. >> >> Note as opposed to other ARC boards we link Linux kernel to >> 0x9000_0000 intentionally because cores 1 and 3 configured with DCCM >> situated at our more usual link base 0x8000_0000. We still can use >> memory region starting at 0x8000_0000 as we reallocate DCCM in our >> platform code. >> >> Note that PAE remapping for DMA clients does not work due to an RTL bug, >> so CREG_PAE register must be programmed to all zeroes, otherwise it will >> cause problems with DMA to/from peripherals even if PAE40 is not used. >> >> Signed-off-by: Alexey Brodkin >> Signed-off-by: Eugeniy Paltsev >> --- >> Changes v7 -> v8: >> * DTS: move cpu_intc, idu_intc, arcpct, timer, gfrc nodes to root >> level and out of the cpus node. >> * DTS: add vendor-specific compatible for ohci and ehci nodes. >> * DTS: style fixes > > Acked-by: Rob Herring > >> + ohci@60000 { >> + compatible = "snps,hsdk-v1.0-ohci", "generic-ohci"; >> + reg = <0x60000 0x100>; >> + interrupts = <15>; >> + }; >> + >> + ehci@40000 { >> + compatible = "snps,hsdk-v1.0-ehci", "generic-ehci"; >> + reg = <0x40000 0x100>; >> + interrupts = <15>; >> + }; > > Of course, now these compatibles need to be documented. You can do that > in a separate follow-up patch. Are these v1 suffixes really needed. We don't envision any change to usb IP even if we were to ever do a respin of the board ! Thx, -Vineet