Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751479AbdHaRzl (ORCPT ); Thu, 31 Aug 2017 13:55:41 -0400 Received: from mga07.intel.com ([134.134.136.100]:33092 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbdHaRzk (ORCPT ); Thu, 31 Aug 2017 13:55:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,454,1498546800"; d="scan'208";a="895967764" From: Jani Nikula To: Randy Dunlap , Jonathan Corbet , Mauro Carvalho Chehab Cc: "linux-doc\@vger.kernel.org" , LKML , linux-media Subject: Re: [PATCH 1/2] docs: kernel-doc comments are ASCII In-Reply-To: <58800275-b969-5377-2fd8-da8e13bad344@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <54c23e8e-89c0-5cea-0dcc-e938952c5642@infradead.org> <20170830152314.0486fafb@lwn.net> <3390facf-69ae-ba18-8abe-09b5695a6b31@infradead.org> <20170831064941.1fb18d20@vento.lan> <87h8wn98bv.fsf@intel.com> <20170831105602.5607fe52@vento.lan> <20170831081721.38be05ef@lwn.net> <87d17b90zb.fsf@intel.com> <87a82f8zjc.fsf@intel.com> <58800275-b969-5377-2fd8-da8e13bad344@infradead.org> Date: Thu, 31 Aug 2017 20:55:27 +0300 Message-ID: <877exj8vw0.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2380 Lines: 66 On Thu, 31 Aug 2017, Randy Dunlap wrote: > On 08/31/17 09:36, Jani Nikula wrote: >> On Thu, 31 Aug 2017, Jani Nikula wrote: >>> On Thu, 31 Aug 2017, Randy Dunlap wrote: >>>> On 08/31/17 07:17, Jonathan Corbet wrote: >>>>> On Thu, 31 Aug 2017 10:56:26 -0300 >>>>> Mauro Carvalho Chehab wrote: >>>>> >>>>>> It should have something to do with python version and/or to some >>>>>> locale info at the system, as neither I or Jon can reproduce it. >>>>> >>>>> I can't reproduce it here, but I have certainly seen situations where >>>>> Python 2 wants to run with the ascii codec by default. >>>>> >>>>> Note that the exception happens in our Sphinx extension, not in Sphinx >>>>> itself. We've had other non-ascii text in our docs, so I think Sphinx is >>>>> doing the right thing. The problem is with our own code. If I could >>>>> reproduce it, it shouldn't be too hard to track down - take out that >>>>> massive "except anything" block and see where it explodes. >>>>> >>>>> Randy, which distribution are you running, and are you using their version >>>>> of Sphinx? >>>> >>>> opensuse LEAP 42.2 >>>> Yes, their sphinx 1.3.1. >>> >>> What's your LANG setting? I think that's what it boils down to, and >>> trying to work around non-UTF-8 LANG in both python 2 and 3 compatible >>> ways. >>> >>> The odd thing is that I can reproduce the issue using a small python >>> snippet, but not through Sphinx. >> >> Your original error message suggests your Sphinx actually uses python >> 3. Can you check that? The clue is that it's the *decode* that fails. > > Where do you see that clue? The message, "'ascii' codec can't decode byte 0xe2 in position 6368: ordinal not in range(128)". In my testing I could only get that *decode* error message using python 3. > My /usr/bin/python is linked to python2.7: > >> ll /usr/bin/python > lrwxrwxrwx 1 root root 9 Jun 10 19:59 /usr/bin/python -> python2.7* Sure, but how about 'head $(which sphinx-build)'? I could be completely mistaken too. ;) >> Does the below patch help? It avoids the implicit ascii decoding due to >> universal_newlines=True and your LANG setting, and does explicit utf-8 >> decoding instead. >> >> Fingers crossed. > > testing now. Thanks. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center