Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751708AbdHaT4p (ORCPT ); Thu, 31 Aug 2017 15:56:45 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:34393 "EHLO mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbdHaT4m (ORCPT ); Thu, 31 Aug 2017 15:56:42 -0400 X-Google-Smtp-Source: ADKCNb4aQa0N6sa1J7MIJus8dinsoD31WCDV7Lah5QSNUU6+G3gXLh86CTv599wI0vqBKJwNPi1nuA== Subject: Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL To: Greg Kroah-Hartman , Dan Carpenter Cc: Shaohua Li , linux-block@vger.kernel.org, Tejun Heo , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20170830140456.7n6sfogqb7mvjmrm@mwanda> <20170831165247.GA26219@kroah.com> From: Jens Axboe Message-ID: <26406dc8-2bdc-7bd3-7cd9-7e63986a8769@kernel.dk> Date: Thu, 31 Aug 2017 13:56:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170831165247.GA26219@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 554 Lines: 17 On 08/31/2017 10:52 AM, Greg Kroah-Hartman wrote: > On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote: >> The kernfs_get_inode() returns NULL on error, it never returns error >> pointers. >> >> Fixes: aa8188253474 ("kernfs: add exportfs operations") >> Signed-off-by: Dan Carpenter >> Acked-by: Tejun Heo > > Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I > can't take this patch :( It's in my tree, I'll take it. Can I add your acked/reviewed/whatever-by? -- Jens Axboe