Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751710AbdHaVic (ORCPT ); Thu, 31 Aug 2017 17:38:32 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:58960 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbdHaVia (ORCPT ); Thu, 31 Aug 2017 17:38:30 -0400 Date: Thu, 31 Aug 2017 14:38:27 -0700 (PDT) Message-Id: <20170831.143827.1561921608795766649.davem@davemloft.net> To: lipeng321@huawei.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com Subject: Re: [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports From: David Miller In-Reply-To: <1504186749-8926-8-git-send-email-lipeng321@huawei.com> References: <1504186749-8926-1-git-send-email-lipeng321@huawei.com> <1504186749-8926-8-git-send-email-lipeng321@huawei.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 31 Aug 2017 14:38:30 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 797 Lines: 21 From: Lipeng Date: Thu, 31 Aug 2017 21:39:08 +0800 > Config the self_define vlan_type as TPID(0x8100) for vlan identification. > When normal port initialize vlan configure, set default vlan id as 0. > > Signed-off-by: Mingguang Qu > Signed-off-by: Lipeng No, that's not what this patch is doing. > @@ -3308,6 +3308,7 @@ static int hclge_add_mac_vlan_tbl(struct hclge_vport *vport, > mc_desc[1].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT); > hclge_cmd_reuse_desc(&mc_desc[2], false); > mc_desc[2].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_NEXT); > + > memcpy(mc_desc[0].data, req, > sizeof(struct hclge_mac_vlan_tbl_entry)); > ret = hclge_cmd_send(&hdev->hw, mc_desc, 3); All it does is add an empty line.