Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823AbdHaX2s (ORCPT ); Thu, 31 Aug 2017 19:28:48 -0400 Received: from www17.your-server.de ([213.133.104.17]:57415 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbdHaX2r (ORCPT ); Thu, 31 Aug 2017 19:28:47 -0400 Date: Fri, 1 Sep 2017 01:26:24 +0200 From: Thomas Meyer To: Greg KH Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] vt: Use bsearch library function in is_double_width Message-ID: <20170831232517.nquvomamw4fp5dq4@olymp> References: <20170831130432.19934-1-thomas@m3y3r.de> <20170831142115.28098-1-thomas@m3y3r.de> <20170831150253.GB15886@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170831150253.GB15886@kroah.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Authenticated-Sender: thomas@m3y3r.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 28 On Thu, Aug 31, 2017 at 05:02:53PM +0200, Greg KH wrote: > On Thu, Aug 31, 2017 at 04:21:15PM +0200, Thomas Meyer wrote: > > Use bsearch library function instead of duplicated functionality. > > One question: Having above changelog text and a nearly similar subject line is fine for you? > > v2: Re-introduce early exit from old binary search. > > That's not the difference from the previous patch... It isn't? v2 adds those lines: + if (ucs < double_width[0].first || + ucs > double_width[ARRAY_SIZE(double_width) - 1].last) + return 0; Which is the early exit from the old binary search, i.e. the current implementation What do you mean with "that's not the difference from the previous patch"? > > And that info goes below the --- line, as the documentation states. So besides adding v2 comment below the --- line, what else do you want me to change to accept this patch?