Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbdHaXpm (ORCPT ); Thu, 31 Aug 2017 19:45:42 -0400 Received: from mail-vk0-f52.google.com ([209.85.213.52]:37302 "EHLO mail-vk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbdHaXpj (ORCPT ); Thu, 31 Aug 2017 19:45:39 -0400 X-Google-Smtp-Source: ADKCNb7BOuuwhx8c1P1uyVWRRkShZp/eA+ZW0cXWbz7B7wSZd7zEcbb4vMN+FN+k/AHlF5493HrqFzo/lh1niCVCIFE= MIME-Version: 1.0 In-Reply-To: <1504222183-61202-32-git-send-email-keescook@chromium.org> References: <1504222183-61202-1-git-send-email-keescook@chromium.org> <1504222183-61202-32-git-send-email-keescook@chromium.org> From: Dmitry Torokhov Date: Thu, 31 Aug 2017 16:45:37 -0700 Message-ID: Subject: Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data To: Kees Cook Cc: Thomas Gleixner , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Sean Hefty , Hal Rosenstock , Jeff Kirsher , "linux-pm@vger.kernel.org" , linux-rdma@vger.kernel.org, "linux-input@vger.kernel.org" , intel-wired-lan@lists.osuosl.org, netdev , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 372 Lines: 12 On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote: > In several places, .data is checked for initialization to gate early > calls to del_timer_sync(). Checking for .function is equally valid, so > switch to this in all callers. Not seeing the rest of patches it is unclear from the patch description why this is needed/wanted. Thanks. -- Dmitry