Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791AbdHaX7K (ORCPT ); Thu, 31 Aug 2017 19:59:10 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:35613 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbdHaX7G (ORCPT ); Thu, 31 Aug 2017 19:59:06 -0400 X-Google-Smtp-Source: ADKCNb6W9zUYoiVrK+zBNtNfacAD2+CLLgPOtLv8Exl1oyBJ4AT8gAsCct+DTrHLczY/IDzOhgsk8I3m331NYv02jsU= MIME-Version: 1.0 In-Reply-To: References: <1504222183-61202-1-git-send-email-keescook@chromium.org> <1504222183-61202-32-git-send-email-keescook@chromium.org> From: Kees Cook Date: Thu, 31 Aug 2017 16:59:05 -0700 X-Google-Sender-Auth: wtXEiUSrwLjKzeFxfcsuc1JVUPo Message-ID: Subject: Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data To: Dmitry Torokhov Cc: Thomas Gleixner , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Sean Hefty , Hal Rosenstock , Jeff Kirsher , "linux-pm@vger.kernel.org" , linux-rdma , "linux-input@vger.kernel.org" , intel-wired-lan@lists.osuosl.org, netdev , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 863 Lines: 26 On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov wrote: > On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote: >> In several places, .data is checked for initialization to gate early >> calls to del_timer_sync(). Checking for .function is equally valid, so >> switch to this in all callers. > > Not seeing the rest of patches it is unclear from the patch > description why this is needed/wanted. The CC list would have been really giant, but here is the first patch and the earlier series list: https://lkml.org/lkml/2017/8/31/904 https://lkml.org/lkml/2017/8/30/760 tl;dr: We're going to switch all struct timer_list callbacks to get the timer pointer as the argument instead of from the .data field. This patch is one step in removing open-coded users of the .data field. -Kees -- Kees Cook Pixel Security