Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751795AbdIAAMM (ORCPT ); Thu, 31 Aug 2017 20:12:12 -0400 Received: from mail-io0-f173.google.com ([209.85.223.173]:36826 "EHLO mail-io0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbdIAAMK (ORCPT ); Thu, 31 Aug 2017 20:12:10 -0400 X-Google-Smtp-Source: ADKCNb7kcuJm+fqBiE/OR8I9ezgNwvnHs447fcz0sz/fSGaodRdHVPzzJbHxyf2waevcEMJWbvyKVvJMsgJufP0CNtU= MIME-Version: 1.0 In-Reply-To: References: <1504213298-27431-1-git-send-email-linux@leemhuis.info> From: Linus Torvalds Date: Thu, 31 Aug 2017 17:12:09 -0700 X-Google-Sender-Auth: iVzLorCwOwo0lnWLyLaUV4cb9gg Message-ID: Subject: Re: RFC: Revert move default dialect from CIFS to to SMB3 To: Thorsten Leemhuis Cc: Steve French , Linux Kernel Mailing List , "linux-cifs@vger.kernel.org" , Pavel Shilovsky Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 22 On Thu, Aug 31, 2017 at 2:36 PM, Thorsten Leemhuis wrote: > Lo! To give a bit more background to this (the mail I reply to was the > first I sent with git send-email and I missed some details): Maybe I'm > over stretching my abilities/position as regression tracker with this > RFC for a revert, but I hope it at least triggers a discussion if such a > revert should be done or not. I don't think that a revert is appropriate. But perhaps just a single printk() or something if the user does *not* specify the version explicitly? Just saying something like We used to default to 1.0, we now default to 3.0, if you want old defaults, use "vers=1.0" Oh, looking at that version parsing code, I think we also need to fix that legacy "ver=1" thing (ver without the 's') which now silently ignores "ver=1" as being the "default", even though it's not. I do *not* believe that "default to version 1" is acceptable. Linus