Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751346AbdIABGd (ORCPT ); Thu, 31 Aug 2017 21:06:33 -0400 Received: from mail-ua0-f193.google.com ([209.85.217.193]:36919 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbdIABGb (ORCPT ); Thu, 31 Aug 2017 21:06:31 -0400 X-Google-Smtp-Source: ADKCNb5PX/r/Cql6nyUNxcDUaVKj/WpTDw+iunv2Zn9B//YVHSSYjdpSo/iuNIiPNd8eAVt92SAtcnbePWEd4Gpa6ZE= MIME-Version: 1.0 In-Reply-To: References: <1504222183-61202-1-git-send-email-keescook@chromium.org> <1504222183-61202-32-git-send-email-keescook@chromium.org> From: Dmitry Torokhov Date: Thu, 31 Aug 2017 18:06:29 -0700 Message-ID: Subject: Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data To: Kees Cook Cc: Thomas Gleixner , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Sean Hefty , Hal Rosenstock , Jeff Kirsher , "linux-pm@vger.kernel.org" , linux-rdma , "linux-input@vger.kernel.org" , intel-wired-lan@lists.osuosl.org, netdev , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1099 Lines: 33 On Thu, Aug 31, 2017 at 4:59 PM, Kees Cook wrote: > On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov > wrote: >> On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote: >>> In several places, .data is checked for initialization to gate early >>> calls to del_timer_sync(). Checking for .function is equally valid, so >>> switch to this in all callers. >> >> Not seeing the rest of patches it is unclear from the patch >> description why this is needed/wanted. > > The CC list would have been really giant, but here is the first patch > and the earlier series list: > > https://lkml.org/lkml/2017/8/31/904 > https://lkml.org/lkml/2017/8/30/760 > > tl;dr: We're going to switch all struct timer_list callbacks to get > the timer pointer as the argument instead of from the .data field. > This patch is one step in removing open-coded users of the .data > field. > And that is exactly what should have been in the patch description. FWIW for input bits: Acked-by: Dmitry Torokhov Thanks. -- Dmitry