Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751110AbdIAFAb (ORCPT <rfc822;w@1wt.eu>);
        Fri, 1 Sep 2017 01:00:31 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:46824 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750707AbdIAFA3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 1 Sep 2017 01:00:29 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C3151607A4
Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=guptap@codeaurora.org
Subject: Re: [PATCH 2/2] mm, page_owner: Skip unnecessary stack_trace entries
To: Vlastimil Babka <vbabka@suse.cz>, akpm@linux-foundation.org,
        mhocko@suse.com, will.deacon@arm.com, catalin.marinas@arm.com,
        iamjoonsoo.kim@lge.com, rmk+kernel@arm.linux.org.uk,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <1504078343-28754-1-git-send-email-guptap@codeaurora.org>
 <1504078343-28754-2-git-send-email-guptap@codeaurora.org>
 <82346e0c-176a-dc11-c535-47d023f237a8@suse.cz>
From: Prakash Gupta <guptap@codeaurora.org>
Message-ID: <b890d2a7-addc-1d67-a585-655c3a9f145a@codeaurora.org>
Date: Fri, 1 Sep 2017 10:30:23 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <82346e0c-176a-dc11-c535-47d023f237a8@suse.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1994
Lines: 65


On 8/31/2017 1:04 PM, Vlastimil Babka wrote:
> On 08/30/2017 09:32 AM, Prakash Gupta wrote:
>> The page_owner stacktrace always begin as follows:
>>
>> [<ffffff987bfd48f4>] save_stack+0x40/0xc8
>> [<ffffff987bfd4da8>] __set_page_owner+0x3c/0x6c
> 
> Hmm, on x86_64 it looks like this:
> 
>   save_stack_trace+0x16/0x20
>   save_stack+0x43/0xe0
>   __set_page_owner+0x24/0x50
> 
> So after your patch there's still __set_page_owner. Seems x86 needs
> something similar to your arm64 patch 1/2?

Yes, that's correct.

> 
>> These two entries do not provide any useful information and limits the
>> available stacktrace depth.  The page_owner stacktrace was skipping caller
>> function from stack entries but this was missed with commit f2ca0b557107
>> ("mm/page_owner: use stackdepot to store stacktrace")
>>
>> Example page_owner entry after the patch:
>>
>> Page allocated via order 0, mask 0x8(ffffff80085fb714)
>> PFN 654411 type Movable Block 639 type CMA Flags 0x0(ffffffbe5c7f12c0)
>> [<ffffff9b64989c14>] post_alloc_hook+0x70/0x80
>> ...
>> [<ffffff9b651216e8>] msm_comm_try_state+0x5f8/0x14f4
>> [<ffffff9b6512486c>] msm_vidc_open+0x5e4/0x7d0
>> [<ffffff9b65113674>] msm_v4l2_open+0xa8/0x224
>>
>> Fixes: f2ca0b557107 ("mm/page_owner: use stackdepot to store stacktrace")
>> Signed-off-by: Prakash Gupta <guptap@codeaurora.org>
> 
> The patch itself improves the output regardless of whether we fix the
> x86 internals, so:
> 
> Acked-by: Vlastimil Babka <vbabka@suse.cz>

Thanks.

> 
>> ---
>>   mm/page_owner.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/page_owner.c b/mm/page_owner.c
>> index 10d16fc45bd9..75b7c39bf1df 100644
>> --- a/mm/page_owner.c
>> +++ b/mm/page_owner.c
>> @@ -139,7 +139,7 @@ static noinline depot_stack_handle_t save_stack(gfp_t flags)
>>   		.nr_entries = 0,
>>   		.entries = entries,
>>   		.max_entries = PAGE_OWNER_STACK_DEPTH,
>> -		.skip = 0
>> +		.skip = 2
>>   	};
>>   	depot_stack_handle_t handle;
>>   
>>
>