Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751258AbdIAFHa (ORCPT ); Fri, 1 Sep 2017 01:07:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37348 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbdIAFH2 (ORCPT ); Fri, 1 Sep 2017 01:07:28 -0400 Date: Fri, 1 Sep 2017 07:07:30 +0200 From: Greg Kroah-Hartman To: Jens Axboe Cc: Dan Carpenter , Shaohua Li , linux-block@vger.kernel.org, Tejun Heo , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL Message-ID: <20170901050730.GA2584@kroah.com> References: <20170830140456.7n6sfogqb7mvjmrm@mwanda> <20170831165247.GA26219@kroah.com> <26406dc8-2bdc-7bd3-7cd9-7e63986a8769@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26406dc8-2bdc-7bd3-7cd9-7e63986a8769@kernel.dk> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 19 On Thu, Aug 31, 2017 at 01:56:40PM -0600, Jens Axboe wrote: > On 08/31/2017 10:52 AM, Greg Kroah-Hartman wrote: > > On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote: > >> The kernfs_get_inode() returns NULL on error, it never returns error > >> pointers. > >> > >> Fixes: aa8188253474 ("kernfs: add exportfs operations") > >> Signed-off-by: Dan Carpenter > >> Acked-by: Tejun Heo > > > > Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I > > can't take this patch :( > > It's in my tree, I'll take it. Can I add your > acked/reviewed/whatever-by? Yes: Acked-by: Greg Kroah-Hartman