Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751406AbdIAFJ3 (ORCPT ); Fri, 1 Sep 2017 01:09:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37868 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbdIAFJ2 (ORCPT ); Fri, 1 Sep 2017 01:09:28 -0400 Date: Fri, 1 Sep 2017 07:09:29 +0200 From: Greg Kroah-Hartman To: Kees Cook Cc: Thomas Gleixner , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Ian Abbott Subject: Re: [PATCH 26/31] staging/comedi/das16: Make timer initialization unconditional Message-ID: <20170901050929.GC2584@kroah.com> References: <1504222183-61202-1-git-send-email-keescook@chromium.org> <1504222183-61202-27-git-send-email-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504222183-61202-27-git-send-email-keescook@chromium.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 628 Lines: 15 On Thu, Aug 31, 2017 at 04:29:38PM -0700, Kees Cook wrote: > With timer initialization made unconditional, there is no reason to > make del_timer_sync() calls conditionally, there by removing the test > of the .data field. > > Cc: Ian Abbott > Cc: H Hartley Sweeten > Cc: Greg Kroah-Hartman > Cc: devel@driverdev.osuosl.org > Signed-off-by: Kees Cook > --- > drivers/staging/comedi/drivers/das16.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) Acked-by: Greg Kroah-Hartman