Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751409AbdIAGoD (ORCPT ); Fri, 1 Sep 2017 02:44:03 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56236 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbdIAGoB (ORCPT ); Fri, 1 Sep 2017 02:44:01 -0400 Date: Fri, 1 Sep 2017 08:44:03 +0200 From: Greg KH To: Janani Sankara Babu Cc: insafonov@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4] staging:rtl8188eu:core Rename CamelCase variables Message-ID: <20170901064403.GA5694@kroah.com> References: <1504247462-7308-1-git-send-email-jananis37@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504247462-7308-1-git-send-email-jananis37@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1322 Lines: 27 On Fri, Sep 01, 2017 at 12:01:02PM +0530, Janani Sankara Babu wrote: > This patch is created to solve the CamelCase issue. The members 'IEs' and > 'IELength' of struct wlan_bssid_ex are being modified to 'ie' and > 'ie_length' to solve the issue. And all the places where these variables > are referenced inside rtl8188eu driver are also changed. > > Signed-off-by: Janani Sankara Babu > --- > drivers/staging/rtl8188eu/core/rtw_ap.c | 86 ++++++++++---------- > drivers/staging/rtl8188eu/core/rtw_cmd.c | 26 +++--- > drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 20 ++--- > drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 2 +- > drivers/staging/rtl8188eu/core/rtw_mlme.c | 66 ++++++++-------- > drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 100 ++++++++++++------------ > drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 34 ++++---- > drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 16 ++-- > drivers/staging/rtl8188eu/include/wlan_bssdef.h | 10 +-- > drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 12 +-- > 10 files changed, 186 insertions(+), 186 deletions(-) Where is the changelog here that shows what changed in each version of the patch? That's required, please read the documentation for how to do this properly. thanks, greg k-h