Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751359AbdIAGw2 (ORCPT ); Fri, 1 Sep 2017 02:52:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57210 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbdIAGw1 (ORCPT ); Fri, 1 Sep 2017 02:52:27 -0400 Date: Fri, 1 Sep 2017 08:52:30 +0200 From: Greg KH To: Sherry Yang Cc: linux-kernel@vger.kernel.org, "open list:ANDROID DRIVERS" , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , maco@google.com, tkjos@google.com Subject: Re: [PATCH] android: binder: fixup crash introduced by moving buffer hdr Message-ID: <20170901065230.GA6283@kroah.com> References: <20170831042812.GA3359@kroah.com> <20170831172606.51294-1-sherryy@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170831172606.51294-1-sherryy@android.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 833 Lines: 24 On Thu, Aug 31, 2017 at 10:26:06AM -0700, Sherry Yang wrote: > Fix crash introduced by 74310e06be4d74dcf67cd108366710dee5c576d5 > (android: binder: Move buffer out of area shared with user space) > when close is called after open without mmap in between. > > Signed-off-by: Sherry Yang > --- > drivers/android/binder_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) In the future, please include a "Reported-by:" tag that shows who reported the issue, and a Fixes: tag with the info for what commit this fixes. And no need to give the full sha1, you can shorten it, this is the standard for kernel commit: 74310e06be4d ("android: binder: Move buffer out of area shared with user space") I'll edit this patch up with that info, but in the future, please do this yourself. thanks, greg k-h