Date: Fri, 1 Sep 2017 17:26:09 +0900
From: Stafford Horne <shorne@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Jonas Bonn <jonas@southpole.se>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Openrisc <openrisc@lists.librecores.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [OpenRISC] [PATCH 01/13] openrisc: use shadow registers to save
 regs on exception
Message-ID: <20170901082609.GH2609@lianli.shorne-pla.net>
References: <cover.1504129273.git.shorne@gmail.com>
 <45e5b91f645a51c3c7a7410f0c67676c5c8193e0.1504129273.git.shorne@gmail.com>
 <CAMuHMdWku57oe4Gpm6nW4jK921d4tEzYby8eyC15-oRtXca9fQ@mail.gmail.com>
 <CAMuHMdUWn3qzBp4ezLX0zuReiVStiVxgsFLbz6w4Vp_9qMnxfw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMuHMdUWn3qzBp4ezLX0zuReiVStiVxgsFLbz6w4Vp_9qMnxfw@mail.gmail.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1538
Lines: 44

On Fri, Sep 01, 2017 at 10:03:44AM +0200, Geert Uytterhoeven wrote:
> On Fri, Sep 1, 2017 at 10:02 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On Wed, Aug 30, 2017 at 11:58 PM, Stafford Horne <shorne@gmail.com> wrote:
> >> --- a/arch/openrisc/Kconfig
> >> +++ b/arch/openrisc/Kconfig
> >> @@ -121,6 +121,16 @@ config OPENRISC_NO_SPR_SR_DSX
> >>           Say N here if you know that your OpenRISC processor has
> >>           SPR_SR_DSX bit implemented. Say Y if you are unsure.
> >>
> >> +config OPENRISC_HAVE_SHADOW_GPRS
> >> +       bool "Support for shadow gpr files"
> >
> > default y if SMP?
> 
> Oops, that's not sufficient.
> 
> bool "Support for shadow gpr files" if !SMP
> default y if SMP

Thanks yes, the help text says its mandatory.  That should be forced as you
showed.

-Stafford

> >> +       help
> >> +         Say Y here if your OpenRISC processor features shadowed
> >> +         register files. They will in such case be used as a
> >> +         scratch reg storage on exception entry.
> >> +
> >> +         On SMP systems, this feature is mandatory.
> >> +         On a unicore system it's safe to say N here if you are unsure.
> >> +
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds