Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809AbdIAJu2 (ORCPT ); Fri, 1 Sep 2017 05:50:28 -0400 Received: from mga04.intel.com ([192.55.52.120]:35652 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbdIAJu0 (ORCPT ); Fri, 1 Sep 2017 05:50:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,457,1498546800"; d="scan'208";a="896169587" Date: Fri, 1 Sep 2017 12:45:53 +0300 From: Mika Westerberg To: Bin Meng Cc: Cyrille Pitchen , Marek Vasut , Boris Brezillon , Brian Norris , Richard Weinberger , David Woodhouse , linux-mtd , linux-kernel , Stefan Roese Subject: Re: [PATCH 03/10] spi-nor: intel-spi: Fix broken software sequencing codes Message-ID: <20170901094553.GX2598@lahna.fi.intel.com> References: <1504252841-2445-1-git-send-email-bmeng.cn@gmail.com> <1504252841-2445-4-git-send-email-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504252841-2445-4-git-send-email-bmeng.cn@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 366 Lines: 10 On Fri, Sep 01, 2017 at 01:00:34AM -0700, Bin Meng wrote: > There are two bugs in current intel_spi_sw_cycle(): > > - The 'data byte count' field should be the number of bytes > transferred minus 1 > - SSFSTS_CTL is the offset from ispi->sregs, not ispi->base > > Signed-off-by: Bin Meng This should be tagged for stable inclusion as well.