Date: Fri, 1 Sep 2017 19:55:29 +1000
From: Nicholas Piggin <npiggin@gmail.com>
To: Andrea Parri <parri.andrea@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] swait: add missing barrier to swake_up
Message-ID: <20170901195529.6edca064@roar.ozlabs.ibm.com>
In-Reply-To: <20170901092322.GA4192@andrea>
References: <20170901061450.1450-1-npiggin@gmail.com>
        <20170901092322.GA4192@andrea>
Organization: IBM
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1366
Lines: 36

On Fri, 1 Sep 2017 11:23:22 +0200
Andrea Parri <parri.andrea@gmail.com> wrote:

> On Fri, Sep 01, 2017 at 04:14:50PM +1000, Nicholas Piggin wrote:
> > swake_up and swake_up_all test the swaitqueue outside the lock,
> > but they are missing the barrier that would ensure visibility
> > of a previous store that sets the wakeup condition with the
> > load that tests the swaitqueue. This could lead to a lost wakeup
> > if there is memory reordering. Fix this as prescribed by the
> > waitqueue_active comments.
> > 
> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> > --
> > I noticed this when chasing down that rcu hang bug (which
> > turned out to not be anything of the sort). I might be missing
> > something here and it's safe somehow, but if so then it should
> > have a comment where it diverges from normal waitqueues.
> > 
> > It looks like there's a few callers which are also testing
> > swait_active before swake_up without a barrier which look wrong,
> > so I must be missing something but I'm not sure what.  
> 
> Hi Nicholas. I noticed
> 
>   35a2897c2a306cca344ca5c0b43416707018f434
>   ("sched/wait: Remove the lockless swait_active() check in swake_up*()")
> 
> in tip:locking/core.

Oh thanks, I missed that. Should be in 4.14/stable IMO.

As I said as well, several callers have picked up bad habits. RCU
looks okay though.

Thanks,
Nick