Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbdIAKJZ (ORCPT ); Fri, 1 Sep 2017 06:09:25 -0400 Received: from mga02.intel.com ([134.134.136.20]:49535 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbdIAKJY (ORCPT ); Fri, 1 Sep 2017 06:09:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,457,1498546800"; d="scan'208";a="896174376" Date: Fri, 1 Sep 2017 13:09:19 +0300 From: Mika Westerberg To: Bin Meng Cc: Cyrille Pitchen , Marek Vasut , Boris Brezillon , Brian Norris , Richard Weinberger , David Woodhouse , linux-mtd , linux-kernel , Stefan Roese Subject: Re: [PATCH 00/10] spi-nor: intel-spi: Various fixes and enhancements Message-ID: <20170901100919.GZ2598@lahna.fi.intel.com> References: <1504252841-2445-1-git-send-email-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504252841-2445-1-git-send-email-bmeng.cn@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1839 Lines: 38 On Fri, Sep 01, 2017 at 01:00:31AM -0700, Bin Meng wrote: > This series does several bug fixes and clean ups against the intel-spi > spi-nor driver, as well as enhancements to make the driver independent > on the underlying BIOS/bootloader. > > At present the driver uses the HW sequencer for the read/write/erase on > all supported platforms, read_reg/write_reg for BXT, and the SW sequencer > for read_reg/write_reg for BYT/LPT. The way the driver uses the HW and SW > sequencer relies on some programmed register settings and hence creates > unneeded dependencies with the underlying BIOS/bootloader. For example, > the driver unfortunately does not work as expected when booting from > Intel Baytrail FSP based bootloaders like U-Boot, as the Baytrail FSP > does not set up some SPI controller settings to make the driver happy. > Now such limitation has been removed with this series. > > > Bin Meng (10): > spi-nor: intel-spi: Fix number of protected range registers for > BYT/LPT > spi-nor: intel-spi: Remove useless 'buf' parameter in the HW/SW cycle > spi-nor: intel-spi: Fix broken software sequencing codes > spi-nor: intel-spi: Check transfer length in the HW/SW cycle > spi-nor: intel-spi: Use SW sequencer for BYT/LPT > spi-nor: intel-spi: Remove 'Atomic Cycle Sequence' in > intel_spi_write() > spi-nor: intel-spi: Don't assume OPMENU0/1 to be programmed by BIOS > spi-nor: intel-spi: Remove the unnecessary HSFSTS register RW > spi-nor: intel-spi: Rename swseq to swseq_reg in 'struct intel_spi' > spi-nor: intel-spi: Fall back to use SW sequencer to erase > > drivers/mtd/spi-nor/intel-spi.c | 209 +++++++++++++++++++++++++++++----------- > 1 file changed, 151 insertions(+), 58 deletions(-) Nice work! For the whole series, Acked-by: Mika Westerberg