Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbdIAMjC (ORCPT ); Fri, 1 Sep 2017 08:39:02 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:60535 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751777AbdIAMjB (ORCPT ); Fri, 1 Sep 2017 08:39:01 -0400 Date: Fri, 1 Sep 2017 14:38:56 +0200 From: Peter Zijlstra To: Byungchul Park Cc: mingo@kernel.org, tj@kernel.org, boqun.feng@gmail.com, david@fromorbit.com, johannes@sipsolutions.net, oleg@redhat.com, linux-kernel@vger.kernel.org, kernel-team@lge.com Subject: Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation Message-ID: <20170901123856.p2trpebau57yxftc@hirez.programming.kicks-ass.net> References: <004601d3216e$a3702030$ea506090$@lge.com> <20170830091223.xxnh3podtcumlabm@hirez.programming.kicks-ass.net> <004701d32171$ce57d4c0$6b077e40$@lge.com> <20170830112546.GH3240@X58A-UD3R> <20170831080442.5vdgoaijzmrc776x@hirez.programming.kicks-ass.net> <20170831081501.GJ3240@X58A-UD3R> <20170831083453.5tfjofzk7idthsof@hirez.programming.kicks-ass.net> <20170901020512.GK3240@X58A-UD3R> <20170901094747.iv6s532ccuuzpry2@hirez.programming.kicks-ass.net> <20170901101629.GL3240@X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170901101629.GL3240@X58A-UD3R> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 437 Lines: 10 On Fri, Sep 01, 2017 at 07:16:29PM +0900, Byungchul Park wrote: > It would be gone _only_ at the time the history overrun, and then it > will be built again. So, you are wrong. How will it ever be build again? You only ever spawn the worker thread _ONCE_, then it runs lots and lots of works. We _could_ go fix it, but I really don't see it being worth the time and effort, its a few isolated locks inside the kthread/workqueue code.