Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752001AbdIANRu (ORCPT ); Fri, 1 Sep 2017 09:17:50 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:44055 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751715AbdIANRs (ORCPT ); Fri, 1 Sep 2017 09:17:48 -0400 X-AuditID: cbfec7f4-f79ab6d000003290-7c-59a95df9a549 Subject: Re: [PATCH v3 1/3] drm/bridge/synopsys: dsi: Constify funcs structures To: Philippe CORNU , Archit Taneja , Laurent Pinchart , David Airlie , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Yannick Fertre , Benjamin Gaignard , Vincent Abriou , Alexandre Torgue , Maxime Coquelin , Gabriel Fernandez , Ludovic Barre , Fabien Dessenne , Mickael Reulier From: Andrzej Hajda Message-id: <236bae65-f4ed-23da-63c7-e56d2a36b2f6@samsung.com> Date: Fri, 01 Sep 2017 15:17:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-version: 1.0 In-reply-to: <1501593788-21036-2-git-send-email-philippe.cornu@st.com> Content-type: text/plain; charset="utf-8" Content-transfer-encoding: 7bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA01SaUhUURTmvm3eqFO30fTQKgMFRamF4M0yKiRe1I/6I420DflQcUZlRiX7 k7jXuJQa6ky0YJq2GC5otjGN5piKVJpl6aS0uJAmZWmLljNvCv9953zfOd/5LpenlWPsMj46 NkHUx2q0Ks6NaWj90bXxx+EqdYCthyW5XU8oUvO+A5HU7HGWpFrbOdLz7TNHWqsbEUl/20mR 0+euykj33QscabHsJBdnb7Gk/ZGVIgP2NoYMpo+wpPOFhSFZpzO4HVjozsulhCbTgEwwZ5ey Qn/vfU5o/D7ICm+NNkrInw0QPsw8oIWvtav2y8PdtkWI2ugkUe+//ZhbVNa4mY03y08MF19E KWhSdgbJecCBcO56Jydhb3hqvz2P3XglLkfQ9LMSScVXBBlzz/9PVJ1/RUlEBYKhyyMyqfiI oLl6jnKoPPEBsLemMQ7CC5dQkDuR79xF43wa3hRfpR0qDq+D2bq+eUeeV+DtYL/k7mgzeA2M vipgHHgpPggN0yXOAxV4CcwU2p19Od4N1fdHnWvo+TUjU5Kexquh7ua4q+8DaRl9ziMAl/LQ eSWdcXgBXgm1FlqKEwpT14pc2BPGbPWumCugu9DomjUi+JLfJpOKIgRzkyWuia3QbHvGSm6L oKChmJYMFJCdqZSgADkDekm9E0Yac1xv+gLBS8t39izyNS3IZlqQx7Qgj2lBnsuIuY68xESD LlI0BPoZNDpDYmyk3/E4XS2a/4Edc7apO6isNdiKMI9UHorBrZVqJatJMiTrrAh4WuWlmAqv UisVEZrkk6I+7qg+USsarGg5z6h8FCHhmWoljtQkiDGiGC/q/7EUL1+WgjIihyGu6VOKn7x+ tMeu8n6YVxRk7m3ZhiYWb/Ew+db3qHNInNlDp638NaEreXxkjz6s+h5+fWhzcq/7cLDKciO+ ts+yIvnUg71G0pe560+WFviwtedjuPR9f/aW+f3ewPnvqhgw1gQFl4afDQnNbKkYKu/wLvv1 e9Gagv7pL+9UjCFKs2k9rTdo/gLRg5D4fQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnleLIzCtJLcpLzFFi42I5/e/4Vd0fsSsjDZYuUbboPXeSyWLjk9OM Fk0db1ktmg6dYrO48vU9m8WxddsZLVrun2Gy6Jy4hN3i8q45bBZHDjhazPu7ltXi1MFDTBZ3 751gsXjQ8oLV4szVAywW7Z2tbA4CHpf7epk8ds66y+4xu2Mmq8eda3vYPLZ/e8Dqcb/7OJNH /18Dj6c/9jJ7fN4kF8AZ5WaTkZqYklqkkJqXnJ+SmZduqxQa4qZroaSQl5ibaqsUoesbEqSk UJaYUwrkGRmgAQfnAPdgJX27BLeM9rezWQtmc1Y8nz6PsYHxA3sXIyeHhICJxMqpN5ggbDGJ C/fWs3UxcnEICSxhlPjyfgIrhPOMUeLC6wOMIFXCAv4Sb9vaGUESIgIzmCT+NJ5gAXGYBaYy SzzcNRmsSkjgKqPEkYNaIDabgKbE3803geZycPAK2Encm88NEmYRUJV4eWMSC4gtKhAh0ff2 MthJvAKCEj8m3wOLcwq4Sazb85IZpJVZQF1iypRckDCzgLzE5jVvmSFscYnm1pssExgFZyHp noXQMQtJxywkHQsYWVYxiqSWFuem5xYb6RUn5haX5qXrJefnbmIEJoJtx35u2cHY9S74EKMA B6MSD+8KrhWRQqyJZcWVuYcYJTiYlUR4v0StjBTiTUmsrEotyo8vKs1JLT7EaAr02kRmKdHk fGCSyiuJNzQxNLc0NDK2sDA3MlIS51W/3BQpJJCeWJKanZpakFoE08fEwSnVwDgt3X72hRDF 7s6bT5UM/k19sOqROdfxg/L/JHmyN3/MkYlsrSgvNZp3IpDHU+fbyi6fp15TWN79jxMPdTaO OC3hf2+b5Qn5LIkTOc1Zp7pvmT/ZWPjiZEAV0+Xi9FsRi19mZgXsa0hsNwxbsPZfjtHtBoeU 5f1RW2K2d/9YO9NztqeiffiZ90osxRmJhlrMRcWJAL8Jy5UaAwAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170901131744eucas1p26136403dac07d3991cd0b976bee9120c X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-CMS-RootMailID: 20170801132406epcas4p4b3ccec819c12a887d529804c283b7f35 X-RootMTR: 20170801132406epcas4p4b3ccec819c12a887d529804c283b7f35 References: <1501593788-21036-1-git-send-email-philippe.cornu@st.com> <1501593788-21036-2-git-send-email-philippe.cornu@st.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 29 On 01.08.2017 15:23, Philippe CORNU wrote: > Constify dw_mipi_dsi_bridge_funcs as these functions are not supposed > to change at runtime. > > Signed-off-by: Philippe CORNU > Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > index 36f5ccb..63c7a01 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -811,7 +811,7 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge *bridge) > return drm_bridge_attach(bridge->encoder, dsi->panel_bridge, bridge); > } > > -static struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > +static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > .mode_set = dw_mipi_dsi_bridge_mode_set, > .enable = dw_mipi_dsi_bridge_enable, > .post_disable = dw_mipi_dsi_bridge_post_disable, Reviewed-by: Andrzej Hajda -- Regards Andrzej