Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043AbdIAOTW (ORCPT ); Fri, 1 Sep 2017 10:19:22 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:38168 "EHLO mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbdIAOTU (ORCPT ); Fri, 1 Sep 2017 10:19:20 -0400 X-Google-Smtp-Source: ADKCNb7xNJIT8Qp1clnA4BGDXVCkPc5nWWPrXOhDccBzF7cqxHxxyYYrRdmd6NgYBYWF0Z/iAyXebQ== Subject: Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL To: Dan Carpenter , Shaohua Li , linux-block@vger.kernel.org Cc: Tejun Heo , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org References: <20170830140456.7n6sfogqb7mvjmrm@mwanda> From: Jens Axboe Message-ID: <615eb575-b64f-c315-f1e8-800a2652aa5e@kernel.dk> Date: Fri, 1 Sep 2017 08:19:18 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170830140456.7n6sfogqb7mvjmrm@mwanda> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 195 Lines: 8 On 08/30/2017 08:04 AM, Dan Carpenter wrote: > The kernfs_get_inode() returns NULL on error, it never returns error > pointers. Added for 4.14, with the ack from Tejun and Greg. -- Jens Axboe