Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752104AbdIAPg0 (ORCPT ); Fri, 1 Sep 2017 11:36:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:44810 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbdIAPgZ (ORCPT ); Fri, 1 Sep 2017 11:36:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D9CD21978 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 1 Sep 2017 12:36:20 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: kan.liang@intel.com, mingo@redhat.com, linux-kernel@vger.kernel.org, peterz@infradead.org, eranian@google.com, tglx@linutronix.de, ak@linux.intel.com Subject: Re: [PATCH V2 1/5] perf tools: support new sample type for physical address Message-ID: <20170901153620.GL4831@kernel.org> References: <1504026672-7304-1-git-send-email-kan.liang@intel.com> <1504026672-7304-2-git-send-email-kan.liang@intel.com> <20170901152814.GA21673@krava.homenet.telecomitalia.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170901152814.GA21673@krava.homenet.telecomitalia.it> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2141 Lines: 77 Em Fri, Sep 01, 2017 at 05:28:27PM +0200, Jiri Olsa escreveu: > On Tue, Aug 29, 2017 at 01:11:08PM -0400, kan.liang@intel.com wrote: > > SNIP > > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > > index a5888c7..228a78d 100644 > > --- a/tools/perf/util/evsel.c > > +++ b/tools/perf/util/evsel.c > > @@ -950,6 +950,9 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, > > if (opts->sample_address) > > perf_evsel__set_sample_bit(evsel, DATA_SRC); > > > > + if (opts->sample_phys_addr) > > + perf_evsel__set_sample_bit(evsel, PHYS_ADDR); > > + > > if (opts->no_buffering) { > > attr->watermark = 0; > > attr->wakeup_events = 1; > > @@ -2201,6 +2204,12 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event, > > } > > } > > > > + data->phys_addr = 0; > > + if (type & PERF_SAMPLE_PHYS_ADDR) { > > + data->phys_addr = *array; > > + array++; > > + } > > + > > return 0; > > } > > > > @@ -2306,6 +2315,9 @@ size_t perf_event__sample_event_size(const struct perf_sample *sample, u64 type, > > } > > } > > > > + if (type & PERF_SAMPLE_PHYS_ADDR) > > + result += sizeof(u64); > > + > > return result; > > } > > > > @@ -2495,6 +2507,11 @@ int perf_event__synthesize_sample(union perf_event *event, u64 type, > > } > > } > > > > + if (type & PERF_SAMPLE_PHYS_ADDR) { > > + *array = sample->phys_addr; > > + array++; > > + } > > + > > return 0; > > } > > > > missing the printing bits I'm folding this one there then, - Arnaldo > jirka > > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index e705c0d59a69..4bb89373eb52 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -1467,7 +1467,7 @@ static void __p_sample_type(char *buf, size_t size, u64 value) > bit_name(PERIOD), bit_name(STREAM_ID), bit_name(RAW), > bit_name(BRANCH_STACK), bit_name(REGS_USER), bit_name(STACK_USER), > bit_name(IDENTIFIER), bit_name(REGS_INTR), bit_name(DATA_SRC), > - bit_name(WEIGHT), > + bit_name(WEIGHT), bit_name(PHYS_ADDR), > { .name = NULL, } > }; > #undef bit_name