Message-ID: <3F074F74.2090308@hipac.org>
Date: Sun, 06 Jul 2003 00:21:40 +0200
From: Thomas Heinz <creatix@hipac.org>
Reply-To: Thomas Heinz <creatix@hipac.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.0.0) Gecko/20020623 Debian/1.0.0-0.woody.1
MIME-Version: 1.0
To: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: tc stack overflow
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1118
Lines: 35

Hi

Have you already crashed your kernel today? No? Well, try this one:

# tc qdisc add dev eth0 root handle 1: prio \
   for i in `seq 500` ; do tc qdisc add dev eth0 \
       parent $i:1 handle `expr $i + 1`: prio ; done ; \
   ping 1.2.3.4

[replace eth0 by a device of your choice]


I think some of you are aware of the problem but strangely I didn't
find any mention on linux-kernel or linux-netdev or lartc.

The problem is that the depth of the classification tree is not limited
in any way and since for every qdisc the corresponding enqueue function
is called we have a stack overflow here.

IMO the problem could be fixed by adding a depth parameter to the
enqueue function. This way the function can decide whether it is save
to go deeper down the tree (maybe subject to a global policy).

So, what do you think about the issue? Do you care?


Regards,

Thomas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/