Date: Fri, 1 Sep 2017 18:33:12 +0200
From: Joerg Roedel <joro@8bytes.org>
To: Suman Anna <s-anna@ti.com>
Cc: iommu@lists.linux-foundation.org, Tony Lindgren <tony@atomide.com>,
        Tero Kristo <t-kristo@ti.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iommu/omap: Add support to program multiple iommus
Message-ID: <20170901163312.GM19533@8bytes.org>
References: <20170831131402.29502-1-s-anna@ti.com>
 <20170831131402.29502-3-s-anna@ti.com>
 <20170901100141.2ooccy7ns2fwxceg@8bytes.org>
 <d8b503a1-eaff-e4cc-215d-92520a91e205@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d8b503a1-eaff-e4cc-215d-92520a91e205@ti.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 740
Lines: 17

Hi Suman,
On Fri, Sep 01, 2017 at 11:21:45AM -0500, Suman Anna wrote:
> It's primarily a question of whether each iommu platform device need to
> be represented as a unique iommu_device or not. If you still think that
> both these need to be presented to iommu core as one device, I would
> have to add some glue logic in probe to tie the two devices together.

I think that you should only call iommu_device_register and friends for
the mmu-device you link the other devices against in .add_device.
Otherwise people will see two mmus in sysfs, one of them with no devices
behind it. That is inconsistent with the rest of the patch-set, which
basically handles bots mmus as one. But changing that should be easy, I
think.

Regards,

	Joerg