Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752333AbdIAQzy (ORCPT ); Fri, 1 Sep 2017 12:55:54 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:34864 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbdIAQzw (ORCPT ); Fri, 1 Sep 2017 12:55:52 -0400 X-Google-Smtp-Source: ADKCNb4D/HA2yQ/m32hTjdGe1WNKcX6w7M6apqvwZrW/FqbwZ8txbI++Xu1sAwk8atL3CRenweuIIk12UYn7FOwxeMs= MIME-Version: 1.0 In-Reply-To: <20170901094832.inwuzxczxs4b2ehh@hirez.programming.kicks-ass.net> References: <1504095773-22895-1-git-send-email-elena.reshetova@intel.com> <20170901094832.inwuzxczxs4b2ehh@hirez.programming.kicks-ass.net> From: Kees Cook Date: Fri, 1 Sep 2017 09:55:51 -0700 X-Google-Sender-Auth: 7cMVCstXHZmVPnUDqlTqZol0rU0 Message-ID: Subject: Re: [PATCH 00/15] v5 kernel core pieces refcount conversions To: Peter Zijlstra Cc: Elena Reshetova , Andrew Morton , LKML , "linux-fsdevel@vger.kernel.org" , Greg KH , Al Viro , Tejun Heo , Ingo Molnar , Johannes Weiner , Li Zefan , Arnaldo Carvalho de Melo , Alexander Shishkin , Eric Paris , Arnd Bergmann , Andy Lutomirski , Thomas Gleixner , dvhart@infradead.org, "Eric W. Biederman" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 33 On Fri, Sep 1, 2017 at 2:48 AM, Peter Zijlstra wrote: > On Thu, Aug 31, 2017 at 04:48:00PM -0700, Kees Cook wrote: >> On Wed, Aug 30, 2017 at 5:22 AM, Elena Reshetova >> wrote: >> > Now we have at least x86 support for ARCH_HAS_REFCOUNT merged and >> > arm and others on their way. >> > >> > Changes in v5: >> > * Kees catched that the following changes in >> > perf_event_context.refcount and futex_pi_state.refcount >> > are not correct now when ARCH_HAS_REFCOUNT is enabled: >> > - WARN_ON(!atomic_inc_not_zero(refcount)); >> > + refcount_inc(refcount); >> > So they are now changed back to using refcount_inc_not_zero. >> >> Thanks! >> >> Reviewed-by: Kees Cook >> >> Andrew, are you able to carry these patches in -mm, since they span a >> bunch of core kernel areas? > > No.. these patches should go through the regular trees that maintain > these various parts. Okay, sounds fine. Elena, can you split these up? (You'll probably have to examine MAINTAINERS and/or git history for each patch...) -Kees -- Kees Cook Pixel Security