Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752529AbdIARJw (ORCPT ); Fri, 1 Sep 2017 13:09:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51934 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752490AbdIARJv (ORCPT ); Fri, 1 Sep 2017 13:09:51 -0400 Date: Fri, 1 Sep 2017 19:09:54 +0200 From: Greg KH To: Janani Sankara Babu Cc: insafonov@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5] staging:rtl8188eu:core Rename CamelCase variables Message-ID: <20170901170954.GA25866@kroah.com> References: <1504249859-8861-1-git-send-email-jananis37@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504249859-8861-1-git-send-email-jananis37@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1999 Lines: 47 On Fri, Sep 01, 2017 at 12:40:59PM +0530, Janani Sankara Babu wrote: > This patch is created to solve the CamelCase issue. The members 'IEs' > and 'IELength' of struct wlan_bssid_ex are being modified to 'ie' and > 'ie_length' to solve the issue. And the places where these variables > are referenced inside rtl8188eu driver are also changed. > > Signed-off-by: Janani Sankara Babu > --- > Changelog > [Patch 1/2] : Replace 'IELength' and 'IEs' of struct wlan_bssid_ex with > 'ie_length' and 'ies' > [Patch 2/2] : Remove wrongly commented out lines from the code and rename > 'ies' to 'ie' as per suggestions > V3 : Merge all changes into single patch > V4 : Rebased the patch > V5 : Added the changelog I have no idea what you rebased this against, but it still does not apply: checking file drivers/staging/rtl8188eu/core/rtw_ap.c Hunk #4 FAILED at 119. Hunk #5 FAILED at 129. Hunk #13 FAILED at 583. Hunk #26 FAILED at 1043. Hunk #32 FAILED at 1719. Hunk #33 FAILED at 1754. Hunk #34 FAILED at 1763. 7 out of 34 hunks FAILED checking file drivers/staging/rtl8188eu/core/rtw_cmd.c checking file drivers/staging/rtl8188eu/core/rtw_ieee80211.c checking file drivers/staging/rtl8188eu/core/rtw_ioctl_set.c checking file drivers/staging/rtl8188eu/core/rtw_mlme.c Hunk #9 succeeded at 1662 (offset -3 lines). Hunk #10 succeeded at 1686 (offset -3 lines). Hunk #11 succeeded at 1744 (offset -8 lines). Hunk #12 succeeded at 1758 (offset -8 lines). Hunk #13 succeeded at 1767 (offset -8 lines). Hunk #14 succeeded at 1858 (offset -8 lines). checking file drivers/staging/rtl8188eu/core/rtw_mlme_ext.c Hunk #23 succeeded at 4953 (offset 2 lines). Hunk #24 succeeded at 5012 (offset 2 lines). Hunk #25 succeeded at 5390 (offset 2 lines). checking file drivers/staging/rtl8188eu/core/rtw_wlan_util.c checking file drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c checking file drivers/staging/rtl8188eu/include/wlan_bssdef.h checking file drivers/staging/rtl8188eu/os_dep/ioctl_linux.c