Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752377AbdIAUHh (ORCPT ); Fri, 1 Sep 2017 16:07:37 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:36760 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213AbdIAUHg (ORCPT ); Fri, 1 Sep 2017 16:07:36 -0400 X-Google-Smtp-Source: ADKCNb4Up8Dd//yF8RzzYRXJs1WROWv+uDbz9sXIu0LoceomrU2xkqwITwDcnY9EUNL9crFNPgdwmQ== Subject: Re: [PATCH 13/31] timer: Remove meaningless .data/.function assignments To: Kees Cook , Thomas Gleixner Cc: Krzysztof Halasa , Aditya Shankar , Ganesh Krishna , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1504222183-61202-1-git-send-email-keescook@chromium.org> <1504222183-61202-14-git-send-email-keescook@chromium.org> From: Jens Axboe Message-ID: Date: Fri, 1 Sep 2017 14:07:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1504222183-61202-14-git-send-email-keescook@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 322 Lines: 11 On 08/31/2017 05:29 PM, Kees Cook wrote: > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. For amiflop: Acked-by: Jens Axboe -- Jens Axboe