Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656AbdIAViQ (ORCPT ); Fri, 1 Sep 2017 17:38:16 -0400 Received: from mail-bl2nam02on0137.outbound.protection.outlook.com ([104.47.38.137]:45625 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752503AbdIAViP (ORCPT ); Fri, 1 Sep 2017 17:38:15 -0400 From: Ryan Lee To: Mark Brown CC: "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "kuninori.morimoto.gx@renesas.com" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "ryan.lee.maxim@gmail.com" Subject: RE: [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking Thread-Topic: [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking Thread-Index: AQHTIFXIW2gJ5z7xQECiRg52pGitIaKeXDCAgAI4XdA= Date: Fri, 1 Sep 2017 21:38:13 +0000 Message-ID: References: <1503963061-14763-1-git-send-email-ryans.lee@maximintegrated.com> <1503963061-14763-2-git-send-email-ryans.lee@maximintegrated.com> <20170831114357.dekzz4wa7j6vqi4t@sirena.org.uk> In-Reply-To: <20170831114357.dekzz4wa7j6vqi4t@sirena.org.uk> Accept-Language: en-US, ko-KR Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=RyanS.Lee@maximintegrated.com; x-originating-ip: [204.17.143.20] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY2PR11MB0648;6:1zWKbAMbKI7oEYNBjwGaGlK0Uaa2aIX40fPrCzXNrAhDPRdyj+ybMXchDJ9NWKnO0lcas8BOPunYxgS1SfNZDLyhLN5NsQn2xt7uhgbUoYbmhFuYmshnsFvPQXFa08CXoA1/DfPi/UVZPtCRzNaLHGt2YvpFodf4FeIizAsKXArQglw6HO511TW1a7uKJgCdjBkA5zm28rMpT5gQ11WCLMcBcPRBp5uLxrqHp1Sh7xNBmaEiT5d2T8LsDCeM8EkliZFB9zguaGBj4VqsqnXEgMoiJuv6WPsqXGDphkzPkk4nk+jVxZIIXWM3OQvNtpe9wnAGHUPWFrtrVSMQ40r2VA==;5:yotIpSGLI87wh6GFN68cDSX5H2qYdbnRioSs1vMFPvaHZ88YBGDNdVaRIDR6n5xue8dSBAGQXxvD5XKIxCogTe0CGnVZAsPW0Ojmpz01CXaFzL5gXLd5ljLVEFcItCp2iTced8h18iXQc9Ay6HsdGw==;24:SiwhdX5E8MFDlUV1ay/TsxYsDXjyYs/k2lqfJcfcESQPr3jN2gCgbrOH7fywusxVpq8CXdEsxlVs10Uu05Qa4ZvGAtzgdDk0YI0peeTKkRE=;7:Wj1pbf22X2VEvKLHf4lD4666aSqHpNEA7RK4ucnjxudbwnmeeKKqEwo2/FYGvTCa1YcmiVgjqYkWVEyp0xU+eQA7VSikGZSAF//Xo2TPEc4tBkhQix1JR3fkQpNQAylXFyrl3Z1TKCHiH7YOJjeY7dAPmF/6AS2J/2YlTTEdnITwVRqullbjLvrkpsHt8bgY44pglLgTXUuynDOhtPVZ6oBciS/sXqebBaszwzwzFyU= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 8b770a4f-93be-463b-e428-08d4f181bfe4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BY2PR11MB0648; x-ms-traffictypediagnostic: BY2PR11MB0648: x-exchange-antispam-report-test: UriScan:(9452136761055)(108721460000369); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123560025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR11MB0648;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR11MB0648; x-forefront-prvs: 0417A3FFD2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(189002)(377454003)(13464003)(199003)(24454002)(8676002)(25786009)(229853002)(6116002)(102836003)(3846002)(72206003)(81156014)(39060400002)(7696004)(81166006)(189998001)(7736002)(77096006)(97736004)(2950100002)(6506006)(6916009)(5660300001)(6436002)(345774005)(575784001)(86362001)(478600001)(105586002)(101416001)(53936002)(110136004)(3280700002)(106356001)(3660700001)(2906002)(76176999)(54356999)(55016002)(50986999)(66066001)(4326008)(8936002)(305945005)(2900100001)(6246003)(74316002)(54906002)(68736007)(9686003)(14454004)(99286003)(33656002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR11MB0648;H:BY2PR11MB0837.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: maximintegrated.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2017 21:38:13.6106 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fbd909df-ea69-4788-a554-f24b7854ad03 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR11MB0648 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v81LcKrP016181 Content-Length: 1378 Lines: 33 >-----Original Message----- >From: Mark Brown [mailto:broonie@kernel.org] >Sent: Thursday, August 31, 2017 4:44 AM >To: Ryan Lee >Cc: lgirdwood@gmail.com; perex@perex.cz; tiwai@suse.com; >kuninori.morimoto.gx@renesas.com; alsa-devel@alsa-project.org; linux- >kernel@vger.kernel.org; ryan.lee.maxim@gmail.com >Subject: Re: [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking > >On Mon, Aug 28, 2017 at 04:30:54PM -0700, Ryan Lee wrote: > >> /* Envelope Tracking configuration */ >> regmap_write(max98927->regmap, >> MAX98927_R0082_ENV_TRACK_VOUT_HEADROOM, >> - 0x08); >> + 0x0A); >> regmap_write(max98927->regmap, >> MAX98927_R0086_ENV_TRACK_CTRL, >> 0x01); >> - regmap_write(max98927->regmap, >> - MAX98927_R0087_ENV_TRACK_BOOST_VOUT_READ, >> - 0x10); > >Why are we changing the defaults here? It was understandable to have a fixed >default that differed from the chip value when there was no control but now >there is a control and we're changing the default again for some undocumented >reason. It'd be better to leave the values here to avoid breaking compatibility >with existing users and let users who need different values change things using >the newly added controls. Thank you for feedback. Let me keep existing value. I still need to remove regmap_write for R:0x87 because it is read-only register.