Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752700AbdIAVij (ORCPT ); Fri, 1 Sep 2017 17:38:39 -0400 Received: from mail-sn1nam01on0094.outbound.protection.outlook.com ([104.47.32.94]:47104 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752503AbdIAVih (ORCPT ); Fri, 1 Sep 2017 17:38:37 -0400 From: Ryan Lee To: Mark Brown CC: "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "kuninori.morimoto.gx@renesas.com" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "ryan.lee.maxim@gmail.com" Subject: RE: [PATCH 5/9] ASoC: max98927: Removed obsolete variables Thread-Topic: [PATCH 5/9] ASoC: max98927: Removed obsolete variables Thread-Index: AQHTIFXLp5PHILxWr025klXjql8T86KeXv2AgAI1qeA= Date: Fri, 1 Sep 2017 21:38:33 +0000 Message-ID: References: <1503963061-14763-1-git-send-email-ryans.lee@maximintegrated.com> <1503963061-14763-5-git-send-email-ryans.lee@maximintegrated.com> <20170831115359.bjw3wbihjzcuh3nh@sirena.org.uk> In-Reply-To: <20170831115359.bjw3wbihjzcuh3nh@sirena.org.uk> Accept-Language: en-US, ko-KR Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [204.17.143.20] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY2PR11MB0823;6:fFwlKdVr+PZZodoiqAHmpk4csEjUp8uU2AJWtgnUcmfr9C4wZdXnKpjEhpsNU79WslNunxWDhTzobhIM+xMLL+LqcMwIa5G4SUpXNKV5kOQto084rwwZ3BrOnbSwsNjr37ReivPUTZIK1rWatqoSfiFIfvGucFy8fjaxDkZQRO7BQwzbNsf68EgMgODtefDNzlrQNw3MDDKOp/ifOL6iAwGqn/cPLU25D/FKRVhdOiNqhgA0kzyYUufBQ6T9HNXgSvcE5sUyV8zoIjE52yzdJLdIkrUC4J5//Sy86LqyTgLAP/6IFGsq6vAdgku4e3BcIJo/Wo3tuGRmBdxS+gBnEg==;5:mixFgJeFhKQfFcqFdJWlLnnSiS+pXFMp9vWjOd3eaS9Z7pG+cc7hq+9KwJR+kX0qxd4S5z46eFVNzJn27agl0ZntvJSuYl4n743V7G+VVdIIrM3NaBLU7kg2PMruSh+tmg8LnoMz8KZKMQD8YnRSag==;24:mlt+VEOpBbnqt6KmGpXHTxEOdg696gYE3XXyyuJqTwgTmVJ+2Jh5haXaOZ/pp0q+RmLdTgeKWifrCsMEbHNjYX6Qlrlajk3p5l7sOCAnVa0=;7:RC/2oiCLRciGcR8dQsgd/Mrby0gFDgF94IH02LXy9rWQrPuE/HtCfl+40kD1tZ17qt44dj29Z6HHVLHGx/oF+q7SiJ1g0PPuyRUpcIwyHfK0WHnn8R64ioh+xLqmSdro0BuNmjKEakZkjucL8M1OUng8YT7XNe9JrBLIfhN0bBH7yqCk8WmEqFoakL1yN07fLzmKShfLIL39vM9KP3V5ey/p7TI0xdJEitBrsHaLzew= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 7b0a2519-1dd7-4e9b-e658-08d4f181cbf6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BY2PR11MB0823; x-ms-traffictypediagnostic: BY2PR11MB0823: x-exchange-antispam-report-test: UriScan:(9452136761055)(108721460000369); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123562025)(20161123558100)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR11MB0823;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR11MB0823; x-forefront-prvs: 0417A3FFD2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(54534003)(189002)(377454003)(13464003)(24454002)(199003)(77096006)(76176999)(50986999)(6506006)(5660300001)(25786009)(2950100002)(305945005)(14454004)(4326008)(33656002)(7736002)(6916009)(54356999)(8936002)(101416001)(99286003)(9686003)(8676002)(97736004)(81156014)(81166006)(55016002)(53936002)(189998001)(54906002)(39060400002)(6436002)(68736007)(66066001)(7696004)(105586002)(106356001)(3660700001)(6246003)(72206003)(3280700002)(110136004)(345774005)(74316002)(2900100001)(229853002)(86362001)(2906002)(478600001)(3846002)(102836003)(6116002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR11MB0823;H:BY2PR11MB0837.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=RyanS.Lee@maximintegrated.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: maximintegrated.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2017 21:38:33.9238 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fbd909df-ea69-4788-a554-f24b7854ad03 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR11MB0823 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v81LcjJ3016185 Content-Length: 1090 Lines: 23 >-----Original Message----- >From: Mark Brown [mailto:broonie@kernel.org] >Sent: Thursday, August 31, 2017 4:54 AM >To: Ryan Lee >Cc: lgirdwood@gmail.com; perex@perex.cz; tiwai@suse.com; >kuninori.morimoto.gx@renesas.com; alsa-devel@alsa-project.org; linux- >kernel@vger.kernel.org; ryan.lee.maxim@gmail.com >Subject: Re: [PATCH 5/9] ASoC: max98927: Removed obsolete variables > >On Mon, Aug 28, 2017 at 04:30:57PM -0700, Ryan Lee wrote: >> Signed-off-by: Ryan Lee > >Why are these variables obsolete? If their use was removed in earlier patches in >the series they should be handled in that patch, if they're just unused say so. In >general your changelogs could really benefit from being a bit longer and >explaining why changes are being made. > >> mode change 100644 => 100755 sound/soc/codecs/max98927.h > >This also changes the permissions to be executable which isn't what we want. Thank you for your comment. I wanted to remove these variables because it have never been referred in max98927.c from the beginning.