Subject: Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.
To: Scott Branden <scott.branden@broadcom.com>,
        Eric Anholt <eric@anholt.net>, Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Stefan Wahren <stefan.wahren@i2se.com>,
        bcm-kernel-feedback-list@broadcom.com, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Jon Mason <jonmason@broadcom.com>, devicetree@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>
References: <20170831185416.8181-1-eric@anholt.net>
 <3a947d06-53cc-bb28-86de-0ddb5c6b853c@broadcom.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <2e66788a-228a-b32d-eb31-24fab776ee21@gmail.com>
Date: Fri, 1 Sep 2017 19:10:24 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <3a947d06-53cc-bb28-86de-0ddb5c6b853c@broadcom.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1835
Lines: 55


On 08/31/2017 01:16 PM, Scott Branden wrote:
> Hi Eric,
> 
> mode is correct, location in file needs to be moved.
> 
> 
> On 17-08-31 11:54 AM, Eric Anholt wrote:
>> This doesn't yet enable it on any particular platform, as we still
>> need a panel driver for bcm911360_entphn.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>>
>> These bits are just carving off a little bit of my 911360_entphn panel
>> series, to reduce conflicts when rebasing (which I just did for
>> testing pl111 changes for cygnus regressions).  I'm waiting to get my
>> current RPi panel driver in before working on the 911360 panel again.
>>
>>   arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> index 7c957ea06c66..74f73ff24aec 100644
>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> @@ -575,6 +575,16 @@
>>               status = "disabled";
>>           };
>>   +        clcd: clcd@180a0000 {
> please place in correct address ordered location in file

I moved it right above the v3d node to keep the nodes ordered by unit
address, please check the result here:

https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75

>> +            compatible = "arm,pl111", "arm,primecell";
>> +            reg = <0x180a0000 0x1000>;
>> +            interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
>> +            interrupt-names = "combined";
>> +            clocks = <&axi41_clk>, <&apb_clk>;
>> +            clock-names = "clcdclk", "apb_pclk";
>> +            status = "disabled";
>> +        };
>> +
>>           keypad: keypad@180ac000 {
>>               compatible = "brcm,bcm-keypad";
>>               reg = <0x180ac000 0x14c>;
> 

-- 
Florian