Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058AbdIBFMn (ORCPT ); Sat, 2 Sep 2017 01:12:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54896 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228AbdIBFMl (ORCPT ); Sat, 2 Sep 2017 01:12:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0AD046087C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=riteshh@codeaurora.org Subject: Re: [RFC 3/4] mmc: sdhci-msm: Change the desc_sz on cqe_enable/disable. To: Adrian Hunter , ulf.hansson@linaro.org Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, stummala@codeaurora.org, asutoshd@codeaurora.org References: <1504098251-27739-1-git-send-email-riteshh@codeaurora.org> <1504098251-27739-4-git-send-email-riteshh@codeaurora.org> <10276dbc-81ec-5f4a-fa49-627b25e53ae2@intel.com> From: Ritesh Harjani Message-ID: Date: Sat, 2 Sep 2017 10:42:34 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <10276dbc-81ec-5f4a-fa49-627b25e53ae2@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2087 Lines: 76 On 8/31/2017 12:12 PM, Adrian Hunter wrote: > On 30/08/17 16:04, Ritesh Harjani wrote: >> When CMDQ is halted the HW expects descriptor size to >> be same which is using in CMDQ mode. >> Thus adjust the desc_sz of sdhci accordingly. >> >> Without this patch below command gives ADMA error >> when CQE is enabled. >> cat /sys/kernel/debug/mmc0/mmc0:0001/ext_csd >> >> Signed-off-by: Ritesh Harjani >> --- >> drivers/mmc/host/sdhci-msm.c | 24 ++++++++++++++++++++++-- >> 1 file changed, 22 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >> index 346cdfb..baa3409 100644 >> --- a/drivers/mmc/host/sdhci-msm.c >> +++ b/drivers/mmc/host/sdhci-msm.c >> @@ -1111,9 +1111,29 @@ static u32 sdhci_msm_cqe_irq(struct sdhci_host *host, u32 intmask) >> return 0; >> } >> >> +void sdhci_msm_cqe_enable(struct mmc_host *mmc) >> +{ >> + struct sdhci_host *host = mmc_priv(mmc); >> + >> + if (host->flags & SDHCI_USE_64_BIT_DMA) >> + host->desc_sz = 12; > > This has no effect. Yes, I added it for the sake of completion. Sure I will check on this. > >> + >> + sdhci_cqe_enable(mmc); >> +} >> + >> +void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery) >> +{ >> + struct sdhci_host *host = mmc_priv(mmc); >> + >> + if (host->flags & SDHCI_USE_64_BIT_DMA) >> + host->desc_sz = 16; > > You can't change the descriptor size this way. If you need 128-bit ADMA > descriptors it must be done in sdhci_setup_host(). Let me again check on this once. I will get back then. Thanks. > >> + >> + sdhci_cqe_disable(mmc, recovery); >> +} >> + >> static const struct cqhci_host_ops sdhci_msm_cqhci_ops = { >> - .enable = sdhci_cqe_enable, >> - .disable = sdhci_cqe_disable, >> + .enable = sdhci_msm_cqe_enable, >> + .disable = sdhci_msm_cqe_disable, >> }; >> >> #ifdef CONFIG_MMC_CQHCI >> > -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.