Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692AbdIBHSX (ORCPT ); Sat, 2 Sep 2017 03:18:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:47257 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbdIBHSV (ORCPT ); Sat, 2 Sep 2017 03:18:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,462,1498546800"; d="scan'208";a="896425451" Date: Sat, 2 Sep 2017 10:16:05 +0300 From: Mika Westerberg To: Hans de Goede Cc: Andy Shevchenko , "Rafael J. Wysocki" , Darren Hart , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices Message-ID: <20170902071605.GH2598@lahna.fi.intel.com> References: <20170814201425.20991-1-hdegoede@redhat.com> <06a1d48c-9f75-4aab-107d-f71ce8ebbb26@redhat.com> <20170901091904.GV2598@lahna.fi.intel.com> <6e064337-6105-2231-a66e-ccb6aba3440a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e064337-6105-2231-a66e-ccb6aba3440a@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 507 Lines: 9 On Fri, Sep 01, 2017 at 11:58:55PM +0200, Hans de Goede wrote: > Given that on the device in question where we need this workaround there > is only ever 1 max17047, including the instance number in the check really > is a non-problem, but if there is a strong preference for me to change > the check over to a _HID check then I can do a v2 doing so. I would still prefer _HID check if possible. Otherwise someone finds this hack later and uses it in another driver thinking it is the right thing to do ;-)