Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752731AbdIBPei (ORCPT ); Sat, 2 Sep 2017 11:34:38 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:54447 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752683AbdIBPeh (ORCPT ); Sat, 2 Sep 2017 11:34:37 -0400 Date: Sat, 2 Sep 2017 17:34:35 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 4/4] net: dsa: assign a master to slave ports Message-ID: <20170902153435.GB21003@lunn.ch> References: <20170831183746.2109-1-vivien.didelot@savoirfairelinux.com> <20170831183746.2109-5-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170831183746.2109-5-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1286 Lines: 39 On Thu, Aug 31, 2017 at 02:37:46PM -0400, Vivien Didelot wrote: > Because each DSA slave port may use a different DSA master port, add a > pointer to a master in the slave structure. This is a preparatory patch > for multiple CPU ports. > > Signed-off-by: Vivien Didelot > --- > net/dsa/dsa_priv.h | 7 ++----- > net/dsa/slave.c | 33 ++++++++++++++++++--------------- > 2 files changed, 20 insertions(+), 20 deletions(-) > > diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h > index 59f155cbbe87..a8cd6cbe4061 100644 > --- a/net/dsa/dsa_priv.h > +++ b/net/dsa/dsa_priv.h > @@ -66,6 +66,8 @@ struct dsa_notifier_vlan_info { > }; > > struct dsa_slave_priv { > + struct dsa_master *master; > + > /* Copy of the master xmit tagging op for faster access in hot path */ > struct sk_buff * (*xmit)(struct sk_buff *skb, > struct net_device *dev); > @@ -179,9 +181,4 @@ extern const struct dsa_device_ops qca_netdev_ops; > /* tag_trailer.c */ > extern const struct dsa_device_ops trailer_netdev_ops; > > -static inline struct net_device *dsa_master_netdev(struct dsa_slave_priv *p) > -{ > - return p->dp->ds->dst->master->netdev; > -} > - Hi Vivien Why remove this helper, when it could become p->master->netdev ? Andrew