Subject: Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.
To: Scott Branden <scott.branden@broadcom.com>,
        Florian Fainelli <f.fainelli@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
        Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Stefan Wahren <stefan.wahren@i2se.com>,
        linux-arm-kernel@lists.infradead.org, Eric Anholt <eric@anholt.net>,
        Jon Mason <jonmason@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        linux-rpi-kernel@lists.infradead.org,
        bcm-kernel-feedback-list@broadcom.com
References: <20170831185416.8181-1-eric@anholt.net>
 <3a947d06-53cc-bb28-86de-0ddb5c6b853c@broadcom.com>
 <2e66788a-228a-b32d-eb31-24fab776ee21@gmail.com>
 <CA+Jzhd+cX6MW9O+BzSU0NDTEgBet=wbgMdwW9A+fi7HVvxAArA@mail.gmail.com>
 <CA+JzhdK9feJzk-TJe5HkHfqZOfDm9gOkDQmSSEHYhcuPu0wX5g@mail.gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <dadebea9-1a8b-9634-dc8e-34c9c99cb2d7@gmail.com>
Date: Sat, 2 Sep 2017 09:25:33 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <CA+JzhdK9feJzk-TJe5HkHfqZOfDm9gOkDQmSSEHYhcuPu0wX5g@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1999
Lines: 57


On 09/02/2017 08:48 AM, Scott Branden wrote:
> Looks good
> 
> On Sep 1, 2017 7:10 PM, "Florian Fainelli" <f.fainelli@gmail.com
> <mailto:f.fainelli@gmail.com>> wrote:
> 
> 
> 
>     On 08/31/2017 01:16 PM, Scott Branden wrote:
>     > Hi Eric,
>     >
>     > mode is correct, location in file needs to be moved.
>     >
>     >
>     > On 17-08-31 11:54 AM, Eric Anholt wrote:
>     >> This doesn't yet enable it on any particular platform, as we still
>     >> need a panel driver for bcm911360_entphn.
>     >>
>     >> Signed-off-by: Eric Anholt <eric@anholt.net <mailto:eric@anholt.net>>
>     >> ---
>     >>
>     >> These bits are just carving off a little bit of my 911360_entphn
>     panel
>     >> series, to reduce conflicts when rebasing (which I just did for
>     >> testing pl111 changes for cygnus regressions).  I'm waiting to get my
>     >> current RPi panel driver in before working on the 911360 panel again.
>     >>
>     >>   arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
>     >>   1 file changed, 10 insertions(+)
>     >>
>     >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
>     >> b/arch/arm/boot/dts/bcm-cygnus.dtsi
>     >> index 7c957ea06c66..74f73ff24aec 100644
>     >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>     >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>     >> @@ -575,6 +575,16 @@
>     >>               status = "disabled";
>     >>           };
>     >>   +        clcd: clcd@180a0000 {
>     > please place in correct address ordered location in file
> 
>     I moved it right above the v3d node to keep the nodes ordered by unit
>     address, please check the result here:
> 
>     https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75
>     <https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75>
> 
> 
> With Moved location
> Acked-by: Scott Branden <scott.branden@broadcom.com
> <mailto:scott.branden@broadcom.com>>

Pushed in place with your tag added, thanks!
-- 
Florian