Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752786AbdIBRJp (ORCPT <rfc822;w@1wt.eu>);
        Sat, 2 Sep 2017 13:09:45 -0400
Received: from mail-io0-f175.google.com ([209.85.223.175]:36342 "EHLO
        mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752732AbdIBRJn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 2 Sep 2017 13:09:43 -0400
X-Google-Smtp-Source: ADKCNb5iidSC6XPUEKBFBr9cjDD13rSmaTqJaUsWTk6gK9bp06lEtxpoOfy+XjCy0OxLS4Q8AFXvEDlkRkOZ4s6tcPk=
MIME-Version: 1.0
In-Reply-To: <1504329770.3249.61.camel@samba.org>
References: <1504213298-27431-1-git-send-email-linux@leemhuis.info>
 <bf90b119-1e94-131b-d7b6-c35934d8d1bf@leemhuis.info> <CA+55aFwUdX3wNYCuWjUTLQGPMCw3peeKeSBfwXb+HuV36OwE+g@mail.gmail.com>
 <59A9A59E.6040205@tlinx.org> <CA+55aFzKhz=xLZNin4OR6DzUXiJMJ0EA=r4W9vN7WiaH7fY8UA@mail.gmail.com>
 <CAH2r5muHqSn=nJ42rwt7r6Mp4hvbNaPYJqEoqvqUS+rDFbxLMg@mail.gmail.com>
 <CA+55aFwUHLxBhOh7DxtjSSnKX6KBj+k+p=_CzE8i_xgq-LNj0A@mail.gmail.com> <1504329770.3249.61.camel@samba.org>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sat, 2 Sep 2017 10:09:42 -0700
X-Google-Sender-Auth: 18mHt_KJuYZ-nrXM-4BKgO3BkO0
Message-ID: <CA+55aFxrXHMcvFe5adUr+0=u+Uwg=bHTn9ix9F0uUvGAkAPx7A@mail.gmail.com>
Subject: Re: RFC: Revert move default dialect from CIFS to to SMB3
To: Andrew Bartlett <abartlet@samba.org>
Cc: Steve French <smfrench@gmail.com>,
        "L. A. Walsh" <linux-cifs@tlinx.org>,
        Thorsten Leemhuis <linux@leemhuis.info>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
        Pavel Shilovsky <pshilov@microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 971
Lines: 34

On Fri, Sep 1, 2017 at 10:22 PM, Andrew Bartlett <abartlet@samba.org> wrote:
>
> My quick research shows:
>
> SMB 2.1 but not SMB3 is on:
>  Windows 7
>  Windows 8
>  Windows 2008
>  Windows 2012
>  Samba 3.6 and earlier (SMB1 only by default)
>
> SMB3 is on:
>  Windows 8.1
>  Windows 2012 R2
>  Windows 10
>  Windows 2016
>  Samba 4.0 and above (released 2012)

But most, if not all, of those SMB3 cases _also_ support SMB2.1,
right?  So the "3.0 _only_" case ends up being a fairly rare case
where things have been explicitly limited, and any previous Linux use
must have had that explicit "vers=3.0" flag anyway?

No?

Anyway, we can't avoid *some* breakage (ie the places that literally
only support 1.0 will have to add the explicit "vers=1.0" to get the
mount).

And I merged the code to add better error reporting yesterday, so
hopefully regardless of the default we choose the breakage is not
nearly as confusing to people any more.

                      Linus