Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbdIBTGd (ORCPT ); Sat, 2 Sep 2017 15:06:33 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34236 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752739AbdIBTGb (ORCPT ); Sat, 2 Sep 2017 15:06:31 -0400 X-Google-Smtp-Source: ADKCNb68/7jV4r5SSsXWqNEfDqVE0HfdKViQ6N1GrhP+4CfjUJpK757bmPH9tcjQZHV4fC3mkbGn8g== Date: Sat, 2 Sep 2017 12:06:29 -0700 From: Guenter Roeck To: Hans de Goede Cc: MyungJoo Ham , Chanwoo Choi , Heikki Krogerus , Darren Hart , Andy Shevchenko , Peter Rosin , Mathias Nyman , platform-driver-x86@vger.kernel.org, devel@driverdev.osuosl.org, Kuppuswamy Sathyanarayanan , Sathyanarayanan Kuppuswamy Natarajan , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH 03/11] mux: consumer.h: Add MUX_USB_* state constant defines Message-ID: <20170902190629.GA30251@roeck-us.net> References: <20170901214845.7153-1-hdegoede@redhat.com> <20170901214845.7153-4-hdegoede@redhat.com> <8a05c405-3649-ac99-d4ca-3e519e1c63a8@roeck-us.net> <3e777501-aa94-70ae-3dc5-f64a15fd9704@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e777501-aa94-70ae-3dc5-f64a15fd9704@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2199 Lines: 61 On Sat, Sep 02, 2017 at 05:59:14PM +0200, Hans de Goede wrote: > Hi, > > On 02-09-17 16:59, Guenter Roeck wrote: > >On 09/01/2017 02:48 PM, Hans de Goede wrote: > >>Add MUX_USB_* state constant defines, which can be used by USB > >>device/host and Type-C polarity/role/altmode mux drivers and consumers > >>to ensure that they agree on the meaning of the mux_control_select() > >>state argument. > >> > >>Signed-off-by: Hans de Goede > >>--- > >> include/linux/mux/consumer.h | 16 ++++++++++++++++ > >> 1 file changed, 16 insertions(+) > >> > >>diff --git a/include/linux/mux/consumer.h b/include/linux/mux/consumer.h > >>index 912dd48a3a5d..e3ec9b4db962 100644 > >>--- a/include/linux/mux/consumer.h > >>+++ b/include/linux/mux/consumer.h > >>@@ -15,6 +15,22 @@ > >> #include > >>+/* > >>+ * Mux state values for USB muxes, used for both USB device/host role muxes > >>+ * as well as for Type-C polarity/role/altmode muxes. > >>+ * > >>+ * MUX_USB_POLARITY_INV may be or-ed together with any other mux-state as > >>+ * inverted-polarity (Type-C plugged in upside down) can happen with any > >>+ * other mux-state. > >>+ */ > >>+#define MUX_USB_POLARITY_INV BIT(0) /* Polarity inverted bit */ > >>+#define MUX_USB_NONE (1 << 1) /* Mux open / not connected */ > > > > > >Why BIT(0) but (1 << 1) and so on ? > > Because the polarity can be or-ed together with any of the other options. > Each option can be selected normal and inverted polarity (connector > inserted upside down). > Ah yes, it is (2 << 1), not (1 << 2). But then why don't the options start with (0 << 1) ? I'll have to look into the series more closely; so far the polarity was a separate parameter to tcpm_mux_set() and the low level API. Guenter > Regards, > > Hans > > >>+#define MUX_USB_DEVICE (2 << 1) /* USB device mode */ > >>+#define MUX_USB_HOST (3 << 1) /* USB host mode */ > >>+#define MUX_USB_HOST_AND_DP_SRC (4 << 1) /* USB host + 2 lanes Display Port */ > >>+#define MUX_USB_DP_SRC (5 << 1) /* 4 lanes Display Port source */ > >>+#define MUX_USB_STATES (6 << 1) > >>+ > >> struct device; > >> struct mux_control; > >> > >