Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494AbdICHPH (ORCPT ); Sun, 3 Sep 2017 03:15:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:45851 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751030AbdICHPG (ORCPT ); Sun, 3 Sep 2017 03:15:06 -0400 Date: Sun, 03 Sep 2017 09:15:03 +0200 Message-ID: From: Takashi Iwai To: Robert Jarzmik Cc: Dmitry Torokhov , Lee Jones , Jaroslav Kysela , Daniel Mack , Haojian Zhuang , Liam Girdwood , Mark Brown , Lars-Peter Clausen , Charles Keepax , alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v6 01/12] ALSA: ac97: split out the generic ac97 registers In-Reply-To: <20170902195414.3699-2-robert.jarzmik@free.fr> References: <20170902195414.3699-1-robert.jarzmik@free.fr> <20170902195414.3699-2-robert.jarzmik@free.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1006 Lines: 30 On Sat, 02 Sep 2017 21:54:03 +0200, Robert Jarzmik wrote: > > Split out from the ac97_codec.h the ac97 generic registers, which can be > used by a codec, typically a generic ac97 codec, and by the ac97 bus, to > scan an ac97 AC-Link. > > This split encompasses all the AC97 standard registers, but not the > codec specific ones. > > In order to have a clean split between former ac97 bus implementation > and the new coming one in sound/ac97, it is safer to not include any > former ac97 includes, excepting in sound/ac97/compat.c. > > Amongst the thing to isolate : > - don't have the struct snd_ac97 in sound/ac97/* (except compat.c) to not > be "fooled" by a definition which would come with ac97_codec.h by > "chance". > - don't have to have snd_a97_*() functions, as they rely on struct > snd_ac97. > - don't want the struct snd_ac97_bus_ops, there is a new one > > Signed-off-by: Robert Jarzmik Reviewed-by: Takashi Iwai thanks, Takashi