Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752868AbdICNOt (ORCPT ); Sun, 3 Sep 2017 09:14:49 -0400 Received: from mail-db5eur01on0061.outbound.protection.outlook.com ([104.47.2.61]:42832 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751617AbdICNOr (ORCPT ); Sun, 3 Sep 2017 09:14:47 -0400 Subject: Re: [PATCH 7/10] net/mlx4_core: Use ARRAY_SIZE macro To: Thomas Meyer , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <1504439110050-939061377-0-diffsplit-thomas@m3y3r.de> <1504439110050-1961876957-7-diffsplit-thomas@m3y3r.de> From: Tariq Toukan Message-ID: Date: Sun, 3 Sep 2017 16:14:38 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1504439110050-1961876957-7-diffsplit-thomas@m3y3r.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: AM5PR0602CA0002.eurprd06.prod.outlook.com (2603:10a6:203:a3::12) To VI1PR05MB1806.eurprd05.prod.outlook.com (2a01:111:e400:7a60::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bcbb3297-bf8e-4569-bb8f-08d4f2cdbe22 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:VI1PR05MB1806; X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB1806;3:zA0fobCNRUU5KuSw+PPZxlVYqEqAp11HcD8Zghqf2YSkFGPYLFzq2MghDSaIczoXkFC+Y3PTJ/QX17GAfhntWfLCA2yYBaChyJ1hZ3pZ7MLScaTfyNfi2YDGFBFizgUzkLyEqnSpPtdBFxfeKZqrcGRiM7n9utjxwKYN0ztzHx8Gra5csWLLlMhYjDw2eBOZn30Qovglgo+gPJAH9ZvmMJxq7WpddOtFKuAl1l1zV3JfC+yeLmRcEX4uL3vRSGFq;25:uODYd9u+1q0LG6rBvLKs6EFTnsjWtjk78FlHm8POSROJgn24Vq5WVdivB79FytCpGwwXed1l86wCXxB8adThWx0VW2OwOC+ix0ng8+SPEqQ8XVCdfnRdwZDn/QiYsTGuNJ2rm3CLghZM18MyNkHhDsrr54TMUMVVNddtxCBguBXgrg9VHlP6mOlbbkDHzj+FjXfhbKZT6JGwJpUxni5KENnIhGWcaOxbP1iJE+ldXtysFlsiVD58RJBtx+qeL0T3T/MeRsGgTf89dKdkYxR1HhyZviMaCro5RryDC1ieUhry5L83BUFqy7wjyCpW6+2BkjCU+BieG/ywJzGIGpQhlA==;31:PSak90vkPYcOhJQuIBelsxawxP32GlvQwvjjsrVosbrJsOBUVesALI9QgJ7r1qQRxCqM5Yjc0ga4UXWxCD9lr/p0m6IkUMqMtLu9zj69d2B8Qq8J1gtV6nW0olnpxvZiRPKy0/6q/2tuZuAISiIhX2C8qdZhgTNU9y+Df6Pvxm1nsaeu5JDaB9pPuRbIBfyBQMPXMCJjvSkLaRpXL8VGIzT7b2Y2cYsAROTs5dHrkE4= X-MS-TrafficTypeDiagnostic: VI1PR05MB1806: X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB1806;20:EndunoPPJSD/GbjHDWCXixibeGzPEnIGF0wxM/ly2byFLDqESFKPZBn7X+Ywu0kyiTbzg6aNX9hPtTrw1DKQf8gA0ADt+v2Ot4AdteZPyv3YOyBsE24rPtgDJO84ApPmLKbqQemUdWZwvpHEmQqY484cQd8q4OLdGYw9Ermq7yzFXo7+7baHdX9N3/0rxbyXN6kLmbcLfsI0WP7Hl3pIA7FDR16Xm8TNIPJ8PBK4rPfxthtRvCI797Rd+VFNWsaCMQZOxXFhOnSkA/k2UfhNs6u45YVxOQ/LyvFvl7nQz2okdvB2C/1OQr8HeY6ptwjT4mnLK8yhsas/VJOHgawxvxDLBz0MXh2s7flxPUt4wc7ujG7hyWlocl+rKAmYGio8I3I/Qv43qplDq7aUXKS95+c6wnwjnWHnPHwdr/x475xn1rkAunlGSyo6mnNJzu+zLjpWXlpmBsPqrOyx1wOflNBxDLAlcTqCV1ceVmUYNnUWQ+flAFfnGTPB8up+8Hlt;4:szjoSfeTh8JuBiDB13CsSD2v7Nmnz/Iz8IEF0Ez2KRIO9M40LnBvmhkJEpJoK/sdS2QtHPwEHMyrLJLCH6qY/yzwhwtulDqJzNsNwKiokOsgvMd792W6xKUs6xeHb4dBucj+6PqmQgeboiV0FrUd7FZhq1dUA5CNnLk1o1DvYT8GzSx5476JeGj9yz5LZhIIGW+VKHhQr1gXW9FrC06cV/Dcs9rZKoaUEZBwfdpGQAtnX84m2JAOtE3ToH1R4izB X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR05MB1806;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR05MB1806; X-Forefront-PRVS: 041963B986 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(7370300001)(4630300001)(6009001)(6049001)(39860400002)(189002)(377454003)(24454002)(199003)(6486002)(77096006)(81156014)(5660300001)(189998001)(65826007)(101416001)(106356001)(105586002)(33646002)(229853002)(97736004)(68736007)(83506001)(4001350100001)(31696002)(81166006)(8676002)(54356999)(76176999)(50986999)(31686004)(2906002)(305945005)(86362001)(7736002)(2950100002)(47776003)(478600001)(230700001)(6666003)(50466002)(7350300001)(3846002)(64126003)(6116002)(53546010)(110136004)(6246003)(65956001)(66066001)(65806001)(36756003)(42186005)(23676002)(53936002)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB1806;H:[10.8.2.253];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=tariqt@mellanox.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA1TUIxODA2OzIzOkUvM3VrNkduU3VwVVpBM3JjVXFXTktQVVFR?= =?utf-8?B?NFF6K0g4bHhnbVo5aU1Sd3hHVDYweW14Qy9hNldycjlwWEpMVEtxTmlhR3dp?= =?utf-8?B?d2NXL2NhYmNDejk3YnRCUm91UUJCZDJaTnFCbWtuN2dReld0SlVXb0psYU10?= =?utf-8?B?OXNPRGFxWUxjYWdXOHpZdDBzZEZTeFByK2tQS0NHV3FIc1VCdVpDcFNENkE4?= =?utf-8?B?bkFOeG1XSUlBZW1xK1FrM3NmWmN2NjcwSTdqMTlsUTBwNzZMYTUyL1dJSjJE?= =?utf-8?B?dkcyZXpIZzQxQlg1SVdpYjlLK1k4U0JiZjM0Q1A4Rkh6emp4RUVkMTIxM1lF?= =?utf-8?B?S1E2MDI4TEFmUDA2anoxMUhvdGxCLzdtVGlabGpUOElCUjVyb2I5bUZjT1Vq?= =?utf-8?B?enhPbXJBYnJ0LzlEek12alFrTlJEYjJHNCtLQmZreEQrY2VpNXB5enpybXh2?= =?utf-8?B?WHlScFpYZGFieDFLbWs2WGNoT3NlQktXT0NQLy9UZUxJRDMwTXllYWpWTVZh?= =?utf-8?B?aFI1cmpDR0RqdWpjbGphdWFIbWk3bUQwbGdZQ1l0LzhMdkIyS1d4NnlqRTkw?= =?utf-8?B?TjdNTVIxRFhwR0Z0R2pYWkRvSFhhNGU0Z0FRaWwwQ3R4b01PYjNZQ3ZCcDly?= =?utf-8?B?L0x6bk5MaVVlM000OVlFNkQrVkFOWnRjSnRWampURVRJUUlaaGtRaWFNN2d5?= =?utf-8?B?U2dpSFlQOTZXQjVNSmJVQjE1UDRPL2tLSi9FbnJuQ21iOWtoMnFwQW5xNDFj?= =?utf-8?B?cEtOMUZ4em9xNWo5MmlZUWNlZGFnRlk0cTkyRlJxK1hXV3JYTzRVT1BONFhG?= =?utf-8?B?MUd3Ym5rS04xREU2N1JIWFY5UytyM2xpQ1VXNlY4ODRnRnZZejdJNm9reWhw?= =?utf-8?B?bEo1c0s5Wlp2bEdFUWx5eW5OTTVRc1M0RXNZTVlpWFBJZm9IOEVVZ2dVYjhG?= =?utf-8?B?YnFZYU9VdnkyQi81S1hXbHZDbTFmWUd6ZFlrL005UHhtOHdpQVdHSFo5R0w3?= =?utf-8?B?NG9HcERtSWxkdVo4WG5lUlFXaVlGLzJsR2dsVWxnbFU0dEFEYmlpQkdxa29D?= =?utf-8?B?eG43cCtWODlxSUVTNW5OUmk4TzFkWnJld3NHUy92c3poVkgwa3owY3RSUWVt?= =?utf-8?B?SUp2cHAvUXpld2plWjdPeS9DQnNUQ1VQcWtkeWp4TER1bDgzMmRGT2Fxc1pk?= =?utf-8?B?cjBMQjg0SVlackdCRUdlSWlYVGY3dVBPcEJWYmo5eFB1eUVlc0ZnL2t6RVhV?= =?utf-8?B?UzFTVnBwVEdOeVJSWUZXMmMzRXoycytTQW5TSG1ZcHRMcXBra3N0aWZXaXBp?= =?utf-8?B?N1FxdWl5WjNPTzFkNmJJSUU0RDlQK01GR2RSVCtpMW5MMjMvYUpVeEVwTjVI?= =?utf-8?B?Zk5IcmZOWjBWUEVkZXhpVzREb2xwaVhndWNUT3pQUk1IaDhFaGpxelEvbG5Z?= =?utf-8?B?ZEVmZVlnc1JubDl6M1crUUljT2pjREh3WG5mV0pmeFF1WXJzK3IyUE1pdVl6?= =?utf-8?B?RkljU2FxdzBhYUUyeFdadnpuMzdmY0NKdTl3UitIOVY5NmQwU2l6eUpKN3pD?= =?utf-8?B?dXBEMWpOeHUyM0x4dXVxS3RJU0l1Mk5NanF1cGRDNzBheHMxWmVjZjRzSHQz?= =?utf-8?B?ZFM1RWNXU09CNmtySXdQNzMwMkxNMU8yTTUxTENwZTB5dWNUMnJRQ2ZsL25F?= =?utf-8?B?dUtoRUtVNGplYUtiV0U4cDlwZS9MWGJ3K3ZpeFBJNHJaUzZGSGl3aklJbVRR?= =?utf-8?B?SnZtQ1FkdklXQ1h5eTJzMHIvWjlSQU4wVWtrcFF6Nkw1bWFOUytiZC81UW02?= =?utf-8?B?QnBGYWdkcWIvMTZ6WkZBT1FEU0RqaHNGRy9XMmltdHVoQXc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB1806;6:xfrwPHGn0tL55f+ZgD6awM41G4oGMW89Mbl2gddieVojNu6LzkVJUJT9CG0qy56nTl53QwFBqwmR1737R9nYou00ARyTLLWh5VnD1iSEqQT3XqyWj8s64KT5hDhVK5OdQGD/mHNeyBprFxJPT2KE3RzuQeK9Elfp9CnrVv+6v9mk9HEkO7vJo98ieUh7WkeBiRR2fciYorHsgNijD0Z7rwGWPMs4QZ+ekaNAaTCuu9uQ7soqrGR/LlBuquNYI/YbjQ2/UeNMKRfvduOT1Zhgsl5xHf45nt0Iuc/ZHvNpAFJRanXSmiudU7xwMHsX0yKjYdv0H2VaZYlHESugAuOKJw==;5:f0DWggWAlPAAJ6EAAzo4OQvqEr0Mjc8knAiGblTefEU8t7eTIxSYzWbb4VYzNvGPsK3BTyC4CAxBTt/h4AWI8rpGRdkn7I4dIo93SPtiUlQOhfkgp3CKqXrhLZL5UWT9ETyB9pT4o+EffoN1Ky92CQ==;24:GrQbkNFG6+Yp+85KlQUIecHegOLw4VEEoEW8dttlmtgkBSYje11WHNiQdbnxBZorCK+sHhDT/fUAdqxq09i1zVQtCQa2N1wUbXnJhJPx8LU=;7:bDNfdmwWkAE8gJwxAKdEptcnlgQfaK2/yEJ8A/hCgy6zgLrjEP0j7kBvNXyYO/F085kZN6Z+sE1WSIDCL6Lzvv1kJ6uUrftbmm0o6qwmvmuQGO4mtAvhdWD1tZADLfD0j69PZAe1uj9onF2uPD4HKbU73THQ19X7yLPC+x/kCJw6lZmtDjcNNAEQHiUKazMiYWiKm9QIVk5t7jydo4VWIMR5j6l5FC6sIfzi6XpYsd4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2017 13:14:42.9965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1806 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 457 Lines: 16 On 03/09/2017 3:19 PM, Thomas Meyer wrote: > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it > yourself. > Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e > 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\) > /ARRAY_SIZE(\1)/g' and manual check/verification. > > Signed-off-by: Thomas Meyer > --- Reviewed-by: Tariq Toukan Thanks Thomas!